Skip to content

iio: accel: adxl345: Add spi-3wire feature

Lothar Rubusch linux-devicetree linux-iio lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest8 patches 1 replyIn review
  2. v67 patches 3 repliesSuperseded
  3. v57 patches 13 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v47 patches13 repliesSuperseded
v36 patches11 repliesSuperseded
v23 patches11 repliesSuperseded
v12 patches10 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8iio: accel: adxl345: Make data_range obsoletedrivers/iio/accel/adxl345_core.c+13 -70 replies
2/8iio: accel: adxl345: Group bus configurationdrivers/iio/accel/adxl345_core.c+6 -60 replies
3/8iio: accel: adxl345: Move defines to headerdrivers/iio/accel/adxl345.h drivers/iio/accel/adxl345_core.c+32 -320 replies
4/8dt-bindings: iio: accel: adxl345: Add spi-3wireDocumentation/devicetree/bindings/iio/accel/adi,adxl345.yaml+2 -00 replies
5/8iio: accel: adxl345: Pass function pointer to coredrivers/iio/accel/adxl345.h drivers/iio/accel/adxl345_core.c drivers/iio/accel/adxl345_i2c.c +1 more+29 -100 replies
6/8iio: accel: adxl345: Reorder probe initializationdrivers/iio/accel/adxl345_core.c+20 -200 replies
7/8iio: accel: adxl345: Add comment to probedrivers/iio/accel/adxl345_core.c+10 -00 replies
8/8iio: accel: adxl345: Add spi-3wire optiondrivers/iio/accel/adxl345.h drivers/iio/accel/adxl345_spi.c+10 -10 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/8
2/8
3/8
4/8R-b
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/8] iio: accel: adxl345: Add spi-3wire feature

Pass a function setup() as pointer from SPI/I2C specific modules to the core module. Implement setup() to pass the spi-3wire bus option, if declared in the device-tree.

In the core module then update data_format register configuration bits instead of overwriting it. The changes allow to remove a data_range field.

---
V1 -> V2: Split into spi-3wire and refactoring
V2 -> V3: Split further, focus on needed changesets
V3 -> V4: Drop "Remove single info instances";
split "Group bus configuration" into separat comment patch; reorder patch set
V4 -> V5: Refrase comments; Align comments to 75; rebuild FORMAT_MASK by
available flags; fix indention
V5 -> V6: Remove FORMAT_MASK by a local variable on call site;
Refrase comments;
Remove unneeded include
V6 -> V7: Restructure optional passing the setup() to core's probe()
Guarantee that initially a regmap_write() was called to init all bits to a defined state
- When a setup() e.g. for 3wire is passed, then call regmap_write() inside the setup(). In the following core's probe() has to call regmap_update()
- When NULL is passed, then call regmap_write() in core's probe()
- Refactoring: remove obvious comments and simplify code

Lothar Rubusch (8):
iio: accel: adxl345: Make data_range obsolete
iio: accel: adxl345: Group bus configuration
iio: accel: adxl345: Move defines to header
dt-bindings: iio: accel: adxl345: Add spi-3wire
iio: accel: adxl345: Pass function pointer to core
iio: accel: adxl345: Reorder probe initialization
iio: accel: adxl345: Add comment to probe
iio: accel: adxl345: Add spi-3wire option

 .../bindings/iio/accel/adi,adxl345.yaml       |  2 +
 drivers/iio/accel/adxl345.h                   | 36 +++++++-
 drivers/iio/accel/adxl345_core.c              | 92 ++++++++++---------
 drivers/iio/accel/adxl345_i2c.c               |  2 +-
 drivers/iio/accel/adxl345_spi.c               | 10 +-
 5 files changed, 94 insertions(+), 48 deletions(-)
Signature · 1 line
2.25.1