iio: accel: adxl345: Add spi-3wire feature
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest8 patches 1 replyIn review
- v67 patches 3 repliesSuperseded
- v57 patches 13 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 7 patches | 13 replies | Superseded | |
| v3 | 6 patches | 11 replies | Superseded | |
| v2 | 3 patches | 11 replies | Superseded | |
| v1 | 2 patches | 10 replies | Superseded |
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | iio: accel: adxl345: Make data_range obsoletedrivers/ | +13 | 0 replies | |
| 2/8 | iio: accel: adxl345: Group bus configurationdrivers/ | +6 | 0 replies | |
| 3/8 | iio: accel: adxl345: Move defines to headerdrivers/ drivers/ | +32 | 0 replies | |
| 4/8 | dt-bindings: iio: accel: adxl345: Add spi-3wireDocumentation/ | +2 | 0 replies | |
| 5/8 | iio: accel: adxl345: Pass function pointer to coredrivers/ drivers/ drivers/ +1 more | +29 | 0 replies | |
| 6/8 | iio: accel: adxl345: Reorder probe initializationdrivers/ | +20 | 0 replies | |
| 7/8 | iio: accel: adxl345: Add comment to probedrivers/ | +10 | 0 replies | |
| 8/8 | iio: accel: adxl345: Add spi-3wire optiondrivers/ drivers/ | +10 | 0 replies |
Reviews trailers per patch
1 of 8 patches has a Reviewed-by or Acked-by.
| Patch | Krzysztof Kozlowski |
|---|---|
| 1/8 | |
| 2/8 | |
| 3/8 | |
| 4/8 | R-b |
| 5/8 | |
| 6/8 | |
| 7/8 | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 0/8] iio: accel: adxl345: Add spi-3wire feature
Pass a function setup() as pointer from SPI/I2C specific modules to the core module. Implement setup() to pass the spi-3wire bus option, if declared in the device-tree.
In the core module then update data_format register configuration bits instead of overwriting it. The changes allow to remove a data_range field.
---
V1 -> V2: Split into spi-3wire and refactoring
V2 -> V3: Split further, focus on needed changesets
V3 -> V4: Drop "Remove single info instances";
split "Group bus configuration" into separat comment patch; reorder patch set
V4 -> V5: Refrase comments; Align comments to 75; rebuild FORMAT_MASK by
available flags; fix indention
V5 -> V6: Remove FORMAT_MASK by a local variable on call site;
Refrase comments;
Remove unneeded include
V6 -> V7: Restructure optional passing the setup() to core's probe()
Guarantee that initially a regmap_write() was called to init all bits to a defined state
- When a setup() e.g. for 3wire is passed, then call regmap_write() inside the setup(). In the following core's probe() has to call regmap_update()
- When NULL is passed, then call regmap_write() in core's probe()
- Refactoring: remove obvious comments and simplify code
Lothar Rubusch (8):
iio: accel: adxl345: Make data_range obsolete
iio: accel: adxl345: Group bus configuration
iio: accel: adxl345: Move defines to header
dt-bindings: iio: accel: adxl345: Add spi-3wire
iio: accel: adxl345: Pass function pointer to core
iio: accel: adxl345: Reorder probe initialization
iio: accel: adxl345: Add comment to probe
iio: accel: adxl345: Add spi-3wire option
.../bindings/iio/accel/adi,adxl345.yaml | 2 + drivers/iio/accel/adxl345.h | 36 +++++++- drivers/iio/accel/adxl345_core.c | 92 ++++++++++--------- drivers/iio/accel/adxl345_i2c.c | 2 +- drivers/iio/accel/adxl345_spi.c | 10 +- 5 files changed, 94 insertions(+), 48 deletions(-)
Signature · 1 line
2.25.1