Skip to content

Add support for NIST P521 to ecdsa

Stefan Berger keyrings linux-crypto lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest13 patches 3 repliesIn review
  2. v713 patches 13 repliesSuperseded

Changes in v8 from the cover letter

- Changed nbits from unsigned int to u32 (5/13)
- Added MODULE_ALIAS_CRYPTO("ecdsa-nist-p521") (11/13)
- Applied R-b & T-b tags from Jarkko
- Rebased on master branch at
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13crypto: ecc - Use ECC_CURVE_NIST_P192/256/384_DIGITS where possiblecrypto/ecc.c+6 -60 replies
2/13crypto: ecdsa - Convert byte arrays with key coordinates to digitscrypto/ecdsa.c include/crypto/internal/ecc.h+30 -50 replies
3/13crypto: ecdsa - Adjust tests on length of key parameterscrypto/ecdsa.c+1 -10 replies
4/13crypto: ecdsa - Extend res.x mod n calculation for NIST P521crypto/ecdsa.c+1 -10 replies
5/13crypto: ecc - Add nbits field to ecc_curve structurecrypto/ecc_curve_defs.h crypto/ecrdsa_defs.h include/crypto/ecc_curve.h+11 -01 reply
6/13crypto: ecc - Implement vli_mmod_fast_521 for NIST p521crypto/ecc.c include/crypto/internal/ecc.h+27 -10 replies
7/13crypto: ecc - Add special case for NIST P521 in ecc_point_multcrypto/ecc.c+4 -10 replies
8/13crypto: ecc - Add NIST P521 curve parameterscrypto/ecc.c crypto/ecc_curve_defs.h include/crypto/ecdh.h+48 -00 replies
9/13crypto: ecdsa - Replace ndigits with nbits where precision is neededcrypto/ecdsa.c+1 -10 replies
10/13crypto: ecdsa - Rename keylen to bufsize where necessarycrypto/ecdsa.c+6 -60 replies
11/13crypto: ecdsa - Register NIST P521 and extend test suitecrypto/ecdsa.c crypto/testmgr.c crypto/testmgr.h+184 -00 replies
12/13crypto: asymmetric_keys - Adjust signature size calculation for NIST P521crypto/asymmetric_keys/public_key.c+13 -10 replies
13/13crypto: x509 - Add OID for NIST P521 and extend parser for itcrypto/asymmetric_keys/x509_cert_parser.c include/linux/oid_registry.h+4 -00 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchLukas WunnerJarkko SakkinenVitaly Chikunov
SeriesT-b
1/13T-b R-b
2/13T-b R-b
3/13T-b R-b T-b
4/13T-b R-b
5/13T-b R-b R-b
6/13T-b R-b
7/13T-b R-b
8/13T-b R-b
9/13T-b R-b
10/13T-b R-b
11/13T-b R-b
12/13R-b T-b R-b
13/13T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 00/13] Add support for NIST P521 to ecdsa

This series adds support for the NIST P521 curve to the ecdsa module to enable signature verification with it.

An issue with the current code in ecdsa is that it assumes that input arrays providing key coordinates for example, are arrays of digits (a 'digit' is a 'u64'). This works well for all currently supported curves, such as NIST P192/256/384, but does not work for NIST P521 where coordinates are 8 digits + 2 bytes long. So some of the changes deal with converting byte arrays to digits and adjusting tests on input byte array lengths to tolerate arrays not providing multiples of 8 bytes.

Regards,
Stefan

v8:
- Changed nbits from unsigned int to u32 (5/13)
- Added MODULE_ALIAS_CRYPTO("ecdsa-nist-p521") (11/13)
- Applied R-b & T-b tags from Jarkko
- Rebased on master branch at
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git

v7:
- Applied T-b tag from Christian to all patches
- Applied R-b tag from Jarkko to some patches
- Rephrased some patch descriptions per Jarkko's request

v6:
- Use existing #defines for number of digits rather than plain numbers (1/13, 6/13) following Bharat's suggestion
- Initialize result from lowest 521 bits of product rather than going through tmp variable (6/13)

v5:
- Simplified ecc_digits_from_bytes as suggested by Lukas (1/12)
- Using nbits == 521 to detect NIST P521 curve rather than strcmp() (5,6/12)
- Nits in patch description and comments (11/12)

v4:
- Followed suggestions by Lukas Wummer (1,5,8/12)
- Use nbits rather than ndigits where needed (8/12)
- Renaming 'keylen' variablest to bufsize where necessary (9/12)
- Adjust signature size calculation for NIST P521 (11/12)

v3:
- Dropped ecdh support
- Use ecc_get_curve_nbits for getting number of bits in NIST P521 curve in ecc_point_mult (7/10)

v2:
- Reformulated some patch descriptions
- Fixed issue detected by krobot
- Some other small changes to the code

Stefan Berger (13):
crypto: ecc - Use ECC_CURVE_NIST_P192/256/384_DIGITS where possible
crypto: ecdsa - Convert byte arrays with key coordinates to digits
crypto: ecdsa - Adjust tests on length of key parameters
crypto: ecdsa - Extend res.x mod n calculation for NIST P521
crypto: ecc - Add nbits field to ecc_curve structure
crypto: ecc - Implement vli_mmod_fast_521 for NIST p521
crypto: ecc - Add special case for NIST P521 in ecc_point_mult
crypto: ecc - Add NIST P521 curve parameters
crypto: ecdsa - Replace ndigits with nbits where precision is needed
crypto: ecdsa - Rename keylen to bufsize where necessary
crypto: ecdsa - Register NIST P521 and extend test suite
crypto: asymmetric_keys - Adjust signature size calculation for NIST

    P521

crypto: x509 - Add OID for NIST P521 and extend parser for it

 crypto/asymmetric_keys/public_key.c       |  14 ++-
 crypto/asymmetric_keys/x509_cert_parser.c |   3 +
 crypto/ecc.c                              |  44 +++++--
 crypto/ecc_curve_defs.h                   |  49 ++++++++
 crypto/ecdsa.c                            |  63 +++++++---
 crypto/ecrdsa_defs.h                      |   5 +
 crypto/testmgr.c                          |   7 ++
 crypto/testmgr.h                          | 146 ++++++++++++++++++++++
 include/crypto/ecc_curve.h                |   2 +
 include/crypto/ecdh.h                     |   1 +
 include/crypto/internal/ecc.h             |  24 +++-
 include/linux/oid_registry.h              |   1 +
 12 files changed, 336 insertions(+), 23 deletions(-)

base-commit: a9a72140536fe02d98bce72a608ccf3ba9008a71

Signature · 1 line
2.43.0