Skip to content

nvmet: debugfs support

Hannes Reinecke linux-nvme 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 9 repliesIn review
  2. v38 patches 14 repliesSuperseded
  3. v27 patches 5 repliesSuperseded

Changes to v3 from the cover letter

- drop patch to add queue entries
- Reviews from Sagi

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7nvmet: add debugfs supportdrivers/nvme/target/Kconfig drivers/nvme/target/Makefile drivers/nvme/target/core.c +3 more+262 -31 reply
2/7nvmet: add 'host_traddr' callback for debugfsdrivers/nvme/target/core.c drivers/nvme/target/debugfs.c drivers/nvme/target/nvmet.h+31 -01 reply
3/7nvmet-tcp: implement host_traddr()drivers/nvme/target/tcp.c+14 -00 replies
4/7nvmet-rdma: implement host_traddr()drivers/nvme/target/rdma.c+12 -00 replies
5/7nvmet-fc: implement host_traddr()drivers/nvme/target/fc.c include/linux/nvme-fc-driver.h+37 -00 replies
6/7nvme-fcloop: implement 'host_traddr'drivers/nvme/target/fcloop.c+11 -00 replies
7/7lpfc_nvmet: implement 'host_traddr'drivers/scsi/lpfc/lpfc_nvmet.c+11 -00 replies

Reviews trailers per patch

3 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSagi GrimbergDaniel WagnerChaitanya Kulkarni
SeriesR-b T-b R-b R-b
1/7
2/7R-b
3/7R-b
4/7R-b
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCHv4 0/7] nvmet: debugfs support

Hi all,

taking up the original patchset for nvmet debugfs I've improved upon that submission by modifying the layout:

/dev/kernel/debug/nvmet
<subsysnqn>
ctrl<cntlid>
port
state
hostnqn
kato
host_traddr

The 'state' attribute is the value of the CSTS register; one can trigger a controller reset by writing 'fatal' into it (to set CSTS.CFS).

As usual, comments and reviews are welcome.

Changes to v3:
- drop patch to add queue entries
- Reviews from Sagi

Changes to v2:
- Move the 'host_traddr' attribute to the controller directory
- Rename callback to 'host_traddr'

Hannes Reinecke (7):
nvmet: add debugfs support
nvmet: add 'host_traddr' callback for debugfs
nvmet-tcp: implement host_traddr()
nvmet-rdma: implement host_traddr()
nvmet-fc: implement host_traddr()
nvme-fcloop: implement 'host_traddr'
lpfc_nvmet: implement 'host_traddr'

 drivers/nvme/target/Kconfig    |   9 ++
 drivers/nvme/target/Makefile   |   1 +
 drivers/nvme/target/core.c     |  30 ++++-
 drivers/nvme/target/debugfs.c  | 202 +++++++++++++++++++++++++++++++++
 drivers/nvme/target/debugfs.h  |  42 +++++++
 drivers/nvme/target/fc.c       |  33 ++++++
 drivers/nvme/target/fcloop.c   |  11 ++
 drivers/nvme/target/nvmet.h    |  12 +-
 drivers/nvme/target/rdma.c     |  12 ++
 drivers/nvme/target/tcp.c      |  14 +++
 drivers/scsi/lpfc/lpfc_nvmet.c |  11 ++
 include/linux/nvme-fc-driver.h |   4 +
 12 files changed, 378 insertions(+), 3 deletions(-)
 create mode 100644 drivers/nvme/target/debugfs.c
 create mode 100644 drivers/nvme/target/debugfs.h
Signature · 1 line
2.35.3