Skip to content

x86/resctrl: Move the resctrl filesystem code to /fs/resctrl

James Morse lkml 11 versions – Applied

Status from this message: The following commit has been merged into the x86/cache branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest25 patches 5 repliesApplied
  2. v1130 patches 28 repliesSuperseded
  3. v1030 patches 17 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v927 patches33 repliesSuperseded
v821 patches47 repliesSuperseded
v749 patches91 repliesSuperseded
v642 patches92 repliesSuperseded
v540 patches61 repliesSuperseded
v439 patches25 repliesSuperseded
v338 patches36 repliesSuperseded
v131 patches147 repliesSuperseded

Patches in v12 Applied

#Subject and filesSizeRepliesApplied
1/25cpumask: relax cpumask_any_but()include/linux/cpumask.h+12 -40 replies
2/25find: add find_first_andnot_bit()include/linux/find.h lib/find_bit.c+36 -00 replies
3/25cpumask: add cpumask_{first,next}_andnot() APIinclude/linux/cpumask.h+59 -00 replies
4/25x86/resctrl: Optimize cpumask_any_housekeeping()arch/x86/kernel/cpu/resctrl/internal.h+7 -210 replies
5/25x86/resctrl: Remove the limit on the number of CLOSIDarch/x86/kernel/cpu/resctrl/rdtgroup.c+35 -160 replies
6/25x86/resctrl: Rename resctrl_sched_in() to begin with "resctrl_arch_"arch/x86/include/asm/resctrl.h arch/x86/kernel/cpu/resctrl/rdtgroup.c arch/x86/kernel/process_32.c +1 more+10 -100 replies
7/25x86/resctrl: Check all domains are offline in resctrl_exit()arch/x86/kernel/cpu/resctrl/rdtgroup.c+33 -00 replies
8/25x86/resctrl: resctrl_exit() teardown resctrl but leave the mount pointarch/x86/kernel/cpu/resctrl/rdtgroup.c+40 -80 replies
9/25x86/resctrl: Drop __init/__exit on assorted symbolsarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c +2 more+13 -130 replies
10/25x86/resctrl: Move is_mba_sc() out of core.carch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/rdtgroup.c+15 -150 replies
11/25x86/resctrl: Add end-marker to the resctrl_event_id enumarch/x86/kernel/cpu/resctrl/monitor.c include/linux/resctrl_types.h+7 -50 replies
12/25x86/resctrl: Expand the width of domid by replacing mon_data_bitsarch/x86/kernel/cpu/resctrl/ctrlmondata.c arch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/rdtgroup.c+106 -360 replies
13/25x86/resctrl: Split trace.harch/x86/kernel/cpu/resctrl/Makefile arch/x86/kernel/cpu/resctrl/monitor.c arch/x86/kernel/cpu/resctrl/monitor_trace.h +2 more+42 -220 replies
14/25x86/resctrl: Add 'resctrl' to the title of the resctrl documentationDocumentation/arch/x86/resctrl.rst+3 -30 replies
15/25fs/resctrl: Add boiler plate for external resctrl codeMAINTAINERS arch/Kconfig arch/x86/Kconfig +16 more+66 -130 replies
16/25x86/resctrl: Move the filesystem bits to headers visible to fs/resctrlarch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/rdtgroup.c include/linux/resctrl.h +1 more+11 -90 replies
17/25x86/resctrl: Move enum resctrl_event_id to resctrl.hinclude/linux/resctrl.h include/linux/resctrl_types.h+10 -100 replies
18/25x86/resctrl: Fix types in resctrl_arch_mon_ctx_{alloc,free}() stubsarch/x86/include/asm/resctrl.h+6 -40 replies
19/25x86/resctrl: Move pseudo lock prototypes to include/linux/resctrl.harch/x86/include/asm/resctrl.h include/linux/resctrl.h+13 -50 replies
20/25x86/resctrl: Squelch whitespace anomalies in resctrl core codearch/x86/kernel/cpu/resctrl/rdtgroup.c+5 -70 replies
21/25x86/resctrl: Prefer alloc(sizeof(*foo)) idiom in rdt_init_fs_context()arch/x86/kernel/cpu/resctrl/rdtgroup.c+1 -10 replies
22/25x86/resctrl: Relax some asm #includesarch/x86/kernel/cpu/resctrl/pseudo_lock.c+2 -10 replies
23/25x86/resctrl: Always initialise rid field in rdt_resources_all[]arch/x86/kernel/cpu/resctrl/core.c+5 -50 replies
24/25x86,fs/resctrl: Move the resctrl filesystem code to live in /fs/resctrlDocumentation/arch/x86/index.rst Documentation/filesystems/index.rst Documentation/filesystems/resctrl.rst +17 more+7525 -73510 replies
25/25MAINTAINERS: Add reviewers for fs/resctrlMAINTAINERS+2 -00 replies

Reviews trailers per patch

All 25 patches have a Reviewed-by or Acked-by.

PatchJames MorseTony LuckReinette ChatreFenghua YuShaopeng TanPeter NewmanAmit Singh TomarShanker DonthineniBabu MogerCarl WorthDave Martin
SeriesT-b
1/25T-b R-b T-b R-b R-b
2/25T-b R-b T-b R-b R-b
3/25T-b R-b T-b R-b R-b
4/25T-b R-b T-b R-b R-b T-b R-b
5/25T-b R-b R-b T-b T-b T-b T-b T-b
6/25T-b R-b R-b R-b T-b R-b T-b T-b T-b T-b T-b
7/25T-b R-b R-b T-b T-b
8/25T-b R-b R-b R-b T-b R-b T-b T-b T-b T-b T-b
9/25T-b R-b R-b R-b T-b R-b T-b T-b T-b T-b T-b
10/25T-b R-b R-b R-b T-b R-b T-b T-b T-b T-b T-b
11/25T-b R-b R-b T-b T-b
12/25T-b R-b R-b T-b T-b
13/25T-b R-b R-b R-b T-b R-b T-b T-b T-b T-b
14/25T-b R-b R-b T-b T-b
15/25T-b R-b R-b R-b T-b R-b T-b T-b T-b T-b T-b
16/25T-b R-b R-b R-b T-b R-b T-b T-b T-b T-b T-b
17/25T-b R-b R-b T-b T-b
18/25T-b R-b R-b T-b T-b
19/25T-b R-b R-b T-b T-b
20/25T-b R-b R-b T-b T-b T-b T-b T-b
21/25T-b R-b R-b T-b T-b T-b T-b T-b
22/25T-b R-b R-b T-b T-b T-b T-b T-b
23/25T-b R-b R-b T-b T-b
24/25T-b R-b R-b
25/25T-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 11 reviewers.

Read the v12 thread

Cover letter [PATCH v12 00/25] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl

Hello!

No code changes since v11 - this is the 'final' form of the series with patches v11:24-29 squashed together. See [v11] for the breakdown.

The first four patches are a series from Yury which I've rebased onto.

This series is based on rc5, and can be retrieved from:
git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/move_to_fs/v12

With the exception of invalid configurations for the configurable-events, there should be no changes in behaviour caused by this series. It is now possible for throttle_mode to report 'undefined', but no known platform will do this. resctrl_exit() is now something that can be called, but x86 doesn't do this.

The driving pattern is to make things like struct rdtgroup private to resctrl. Features like pseudo-lock aren't going to work on arm64, the ability to disable it at compile time is added.

After this, I can start posting the MPAM driver to make use of resctrl on arm64. (What's MPAM? See the cover letter of the first series. [1])

Bugs are still welcome!
Thanks,

James

[v11] https://lore.kernel.org/all/[email protected]
[v10] https://lore.kernel.org/all/[email protected]
[v9] https://lore.kernel.org/all/[email protected]
[v8] https://lore.kernel.org/all/[email protected]
[v7] https://lore.kernel.org/all/[email protected]/
[v6] https://lore.kernel.org/lkml/[email protected]/
[v5] https://lore.kernel.org/r/[email protected]
[v4] https://lore.kernel.org/all/[email protected]/
[v3] https://lore.kernel.org/r/[email protected]
[v2] https://lore.kernel.org/r/[email protected]
[v1] https://lore.kernel.org/r/[email protected]
[1] https://lore.kernel.org/lkml/[email protected]/

Amit Singh Tomar (1):
x86/resctrl: Remove the limit on the number of CLOSID

Dave Martin (3):
x86/resctrl: Squelch whitespace anomalies in resctrl core code x86/resctrl: Prefer alloc(sizeof(*foo)) idiom in rdt_init_fs_context() x86/resctrl: Relax some asm #includes

James Morse (17):
x86/resctrl: Rename resctrl_sched_in() to begin with "resctrl_arch_" x86/resctrl: Check all domains are offline in resctrl_exit() x86/resctrl: resctrl_exit() teardown resctrl but leave the mount point x86/resctrl: Drop __init/__exit on assorted symbols x86/resctrl: Move is_mba_sc() out of core.c
x86/resctrl: Add end-marker to the resctrl_event_id enum x86/resctrl: Expand the width of domid by replacing mon_data_bits x86/resctrl: Split trace.h
x86/resctrl: Add 'resctrl' to the title of the resctrl documentation fs/resctrl: Add boiler plate for external resctrl code x86/resctrl: Move the filesystem bits to headers visible to fs/resctrl x86/resctrl: Move enum resctrl_event_id to resctrl.h x86/resctrl: Fix types in resctrl_arch_mon_ctx_{alloc,free}() stubs x86/resctrl: Move pseudo lock prototypes to include/linux/resctrl.h x86/resctrl: Always initialise rid field in rdt_resources_all[] x86,fs/resctrl: Move the resctrl filesystem code to live in
/fs/resctrl
MAINTAINERS: Add reviewers for fs/resctrl

Yury Norov [NVIDIA] (4):
cpumask: relax cpumask_any_but()
find: add find_first_andnot_bit()
cpumask: add cpumask_{first,next}_andnot() API x86/resctrl: Optimize cpumask_any_housekeeping()

 Documentation/arch/x86/index.rst              |    1 -
 Documentation/filesystems/index.rst           |    1 +
 .../{arch/x86 => filesystems}/resctrl.rst     |    6 +-
 MAINTAINERS                                   |    5 +-
 arch/Kconfig                                  |    8 +
 arch/x86/Kconfig                              |   11 +-
 arch/x86/include/asm/resctrl.h                |   19 +-
 arch/x86/kernel/cpu/resctrl/Makefile          |    2 +
 arch/x86/kernel/cpu/resctrl/core.c            |   31 +-
 arch/x86/kernel/cpu/resctrl/ctrlmondata.c     |  635 ---
 arch/x86/kernel/cpu/resctrl/internal.h        |  399 +-
 arch/x86/kernel/cpu/resctrl/monitor.c         |  918 +---
 arch/x86/kernel/cpu/resctrl/pseudo_lock.c     | 1092 +----
 .../resctrl/{trace.h => pseudo_lock_trace.h}  |   26 +-
 arch/x86/kernel/cpu/resctrl/rdtgroup.c        | 4164 +---------------
 arch/x86/kernel/process_32.c                  |    2 +-
 arch/x86/kernel/process_64.c                  |    2 +-
 fs/Kconfig                                    |    1 +
 fs/Makefile                                   |    1 +
 fs/resctrl/Kconfig                            |   39 +
 fs/resctrl/Makefile                           |    6 +
 fs/resctrl/ctrlmondata.c                      |  661 +++
 fs/resctrl/internal.h                         |  426 ++
 fs/resctrl/monitor.c                          |  929 ++++
 fs/resctrl/monitor_trace.h                    |   33 +
 fs/resctrl/pseudo_lock.c                      | 1105 +++++
 fs/resctrl/rdtgroup.c                         | 4353 +++++++++++++++++
 include/linux/cpumask.h                       |   75 +-
 include/linux/find.h                          |   25 +
 include/linux/resctrl.h                       |   36 +-
 include/linux/resctrl_types.h                 |   16 +-
 lib/find_bit.c                                |   11 +
 32 files changed, 7772 insertions(+), 7267 deletions(-)
 rename Documentation/{arch/x86 => filesystems}/resctrl.rst (99%)
 rename arch/x86/kernel/cpu/resctrl/{trace.h => pseudo_lock_trace.h} (56%)
 create mode 100644 fs/resctrl/Kconfig
 create mode 100644 fs/resctrl/Makefile
 create mode 100644 fs/resctrl/ctrlmondata.c
 create mode 100644 fs/resctrl/internal.h
 create mode 100644 fs/resctrl/monitor.c
 create mode 100644 fs/resctrl/monitor_trace.h
 create mode 100644 fs/resctrl/pseudo_lock.c
 create mode 100644 fs/resctrl/rdtgroup.c
Signature · 1 line
2.39.5