Skip to content

bench: fast in-kernel triggering benchmarks

Andrii Nakryiko bpf 2 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 0 repliesApplied 6/6
  2. v16 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- move new TP closer to BPF test run code;
- rename/move kfunc and register it for fmod_rets (Alexei);
- limit --trig-batch-iters param to [1, 1000] (Alexei).

Patches in v2 All 6 applied

#Subject and filesSizeRepliesApplied
1/6selftests/bpf: rename and clean up userspace-triggered benchmarkstools/testing/selftests/bpf/bench.c tools/testing/selftests/bpf/benchs/bench_trigger.c tools/testing/selftests/bpf/benchs/run_bench_uprobes.sh+49 -730 repliesApplied
2/6selftests/bpf: add batched, mostly in-kernel BPF triggering benchmarkstools/testing/selftests/bpf/bench.c tools/testing/selftests/bpf/benchs/bench_trigger.c tools/testing/selftests/bpf/benchs/run_bench_trigger.sh +1 more+238 -70 repliesApplied
3/6selftests/bpf: remove syscall-driven benchs, keep syscall-count onlytools/testing/selftests/bpf/bench.c tools/testing/selftests/bpf/benchs/bench_trigger.c tools/testing/selftests/bpf/benchs/run_bench_trigger.sh +2 more+42 -2990 repliesApplied
4/6selftests/bpf: lazy-load trigger bench BPF programstools/testing/selftests/bpf/benchs/bench_trigger.c tools/testing/selftests/bpf/progs/trigger_bench.c+42 -120 repliesApplied
5/6bpf: add bpf_modify_return_test_tp() kfunc triggering tracepointinclude/trace/events/bpf_test_run.h kernel/bpf/helpers.c net/bpf/test_run.c+26 -00 repliesApplied
6/6selftests/bpf: add batched tp/raw_tp/fmodret teststools/testing/selftests/bpf/bench.c tools/testing/selftests/bpf/benchs/bench_trigger.c tools/testing/selftests/bpf/benchs/run_bench_trigger.sh +1 more+81 -10 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 bpf-next 0/6] bench: fast in-kernel triggering benchmarks

Remove "legacy" triggering benchmarks which rely on syscalls (and thus syscall overhead is a noticeable part of benchmark, unfortunately). Replace them with faster versions that rely on triggering BPF programs in-kernel through another simple "driver" BPF program. See patch #2 with comparison results.

raw_tp/tp/fmodret benchmarks required adding a simple kfunc in kernel to be able to trigger a simple tracepoint from BPF program (plus it is also allowed to be replaced by fmod_ret programs). This limits raw_tp/tp/fmodret benchmarks to new kernels only, but it keeps bench tool itself very portable and most of other benchmarks will still work on wide variety of kernels without the need to worry about building and deploying custom kernel module. See patches #5 and #6 for details.

v1->v2:
- move new TP closer to BPF test run code;
- rename/move kfunc and register it for fmod_rets (Alexei);
- limit --trig-batch-iters param to [1, 1000] (Alexei).

Andrii Nakryiko (6):
selftests/bpf: rename and clean up userspace-triggered benchmarks selftests/bpf: add batched, mostly in-kernel BPF triggering benchmarks selftests/bpf: remove syscall-driven benchs, keep syscall-count only selftests/bpf: lazy-load trigger bench BPF programs
bpf: add bpf_modify_return_test_tp() kfunc triggering tracepoint selftests/bpf: add batched tp/raw_tp/fmodret tests

 include/trace/events/bpf_test_run.h           |  17 +
 kernel/bpf/helpers.c                          |   1 +
 net/bpf/test_run.c                            |   8 +
 tools/testing/selftests/bpf/bench.c           |  33 +-
 .../selftests/bpf/benchs/bench_trigger.c      | 391 +++++++++---------
 .../selftests/bpf/benchs/run_bench_trigger.sh |  22 +-
 .../selftests/bpf/benchs/run_bench_uprobes.sh |   2 +-
 .../selftests/bpf/progs/trigger_bench.c       |  68 ++-
 8 files changed, 314 insertions(+), 228 deletions(-)
Signature · 1 line
2.43.0