Skip to content

kconfig: fix an unselectable choice in MIPS again, and make sure it never happens

Masahiro Yamada linux-kbuild linux-mips lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2MIPS: move unselectable FIT_IMAGE_FDT_EPM5 out of the "System type" choicearch/mips/Kconfig+9 -90 replies
2/2kconfig: do not reparent the menu inside a choice blockscripts/kconfig/conf.c scripts/kconfig/lkc.h scripts/kconfig/menu.c +1 more+18 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] kconfig: fix an unselectable choice in MIPS again, and make sure it never happens

The reason is already explained here:

https://lore.kernel.org/linux-kbuild/[email protected]/

Commit 5033ad566016 fixed the issue, but the MIPS maintainer simultaneously applied commit 101bd58fde10, which introduced another instance of the same mistake.

I will not ask him to pick up this any more.
That would take two development cycles until this choice structure is banned. Meantime, MIPS would introduce yet another mistake.

I will apply both to my tree.

The second patch makes it an error to stop this whack-a-mole game.

Masahiro Yamada (2):
MIPS: move unselectable FIT_IMAGE_FDT_EPM5 out of the "System type"
choice
kconfig: do not reparent the menu inside a choice block

 arch/mips/Kconfig        | 18 +++++++++---------
 scripts/kconfig/conf.c   |  5 -----
 scripts/kconfig/lkc.h    |  2 +-
 scripts/kconfig/menu.c   | 22 ++++++++++++++++------
 scripts/kconfig/parser.y |  2 +-
 5 files changed, 27 insertions(+), 22 deletions(-)
Signature · 1 line
2.40.1