kconfig: fix an unselectable choice in MIPS again, and make sure it never happens
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | MIPS: move unselectable FIT_IMAGE_FDT_EPM5 out of the "System type" choicearch/ | +9 | 0 replies | |
| 2/2 | kconfig: do not reparent the menu inside a choice blockscripts/ scripts/ scripts/ +1 more | +18 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] kconfig: fix an unselectable choice in MIPS again, and make sure it never happens
The reason is already explained here:
https://lore.kernel.org/linux-kbuild/[email protected]/
Commit 5033ad566016 fixed the issue, but the MIPS maintainer simultaneously applied commit 101bd58fde10, which introduced another instance of the same mistake.
I will not ask him to pick up this any more.
That would take two development cycles until this choice structure is banned. Meantime, MIPS would introduce yet another mistake.
I will apply both to my tree.
The second patch makes it an error to stop this whack-a-mole game.
Masahiro Yamada (2):
MIPS: move unselectable FIT_IMAGE_FDT_EPM5 out of the "System type"
choice
kconfig: do not reparent the menu inside a choice block
arch/mips/Kconfig | 18 +++++++++--------- scripts/kconfig/conf.c | 5 ----- scripts/kconfig/lkc.h | 2 +- scripts/kconfig/menu.c | 22 ++++++++++++++++------ scripts/kconfig/parser.y | 2 +- 5 files changed, 27 insertions(+), 22 deletions(-)
Signature · 1 line
2.40.1