Skip to content

ASoC: Use snd_ctl_find_id_mixer() instead of open-coding

Richard Fitzgerald alsa-devel linux-sound lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 0 repliesSuperseded

Changes in v2 from the cover letter

Only change is in the KUnit test (patch #3) to make the const strings more consty.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ALSA: control: Introduce snd_ctl_find_id_mixer_locked()include/sound/control.h+23 -00 replies
2/3ASoC: soc-card: Use snd_ctl_find_id_mixer() instead of open-codingsound/soc/soc-card.c+4 -170 replies
3/3ASoC: soc-card: Add KUnit test case for snd_soc_card_get_kcontrolsound/soc/Kconfig sound/soc/Makefile sound/soc/soc-card-test.c+196 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTakashi Iwai
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] ASoC: Use snd_ctl_find_id_mixer() instead of open-coding

The first two patches change snd_soc_card_get_kcontrol() to use the core snd_ctl_find_id_mixer() functionality instead of open-coding its own list walk.

The last patch adds a KUnit test for this, which was tested on the original and modified code.

Changes in V2:
Only change is in the KUnit test (patch #3) to make the const strings more consty.

Richard Fitzgerald (3):
ALSA: control: Introduce snd_ctl_find_id_mixer_locked()
ASoC: soc-card: Use snd_ctl_find_id_mixer() instead of open-coding
ASoC: soc-card: Add KUnit test case for snd_soc_card_get_kcontrol

 include/sound/control.h   |  23 +++++
 sound/soc/Kconfig         |   8 ++
 sound/soc/Makefile        |   4 +
 sound/soc/soc-card-test.c | 184 ++++++++++++++++++++++++++++++++++++++
 sound/soc/soc-card.c      |  21 +----
 5 files changed, 223 insertions(+), 17 deletions(-)
 create mode 100644 sound/soc/soc-card-test.c
Signature · 1 line
2.39.2