Skip to content

OMAP mailbox FIFO removal

Andrew Davis linux-remoteproc lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 5 repliesIn review
  2. v113 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Use threaded irq as suggested by Hari and to fix possible "scheduling while atomic" issue
- Use oneshot irq as we do not want to enable the irq again until we clear our the messages
- Rebase on v6.9-rc3

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13mailbox: omap: Remove unused omap_mbox_{enable,disable}_irq() functionsdrivers/mailbox/omap-mailbox.c include/linux/omap-mailbox.h+10 -350 replies
2/13mailbox: omap: Remove unused omap_mbox_request_channel() functiondrivers/mailbox/omap-mailbox.c include/linux/omap-mailbox.h+0 -420 replies
3/13mailbox: omap: Move omap_mbox_irq_t into driverdrivers/mailbox/omap-mailbox.c include/linux/omap-mailbox.h+5 -40 replies
4/13mailbox: omap: Move fifo size check to point of usedrivers/mailbox/omap-mailbox.c+5 -50 replies
5/13mailbox: omap: Remove unneeded header omap-mailbox.hdrivers/mailbox/omap-mailbox.c+2 -50 replies
6/13mailbox: omap: Remove device classdrivers/mailbox/omap-mailbox.c+2 -870 replies
7/13mailbox: omap: Use devm_pm_runtime_enable() helperdrivers/mailbox/omap-mailbox.c+3 -150 replies
8/13mailbox: omap: Merge mailbox child node setup loopsdrivers/mailbox/omap-mailbox.c+46 -730 replies
9/13mailbox: omap: Use function local struct mbox_controllerdrivers/mailbox/omap-mailbox.c+12 -90 replies
10/13mailbox: omap: Use mbox_controller channel list directlydrivers/mailbox/omap-mailbox.c+11 -310 replies
11/13mailbox: omap: Remove mbox_chan_to_omap_mbox()drivers/mailbox/omap-mailbox.c+3 -110 replies
12/13mailbox: omap: Reverse FIFO busy check logicdrivers/mailbox/omap-mailbox.c+16 -170 replies
13/13mailbox: omap: Remove kernel FIFO message queuingdrivers/mailbox/Kconfig drivers/mailbox/omap-mailbox.c+5 -1110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/13] OMAP mailbox FIFO removal

Hello all,

Core of this series is the last patch removing the message FIFO from OMAP mailbox. This hurts our real-time performance. It was a legacy leftover from before the common mailbox framework anyway.

The rest of the patches are cleanups found along the way.

Thanks,
Andrew

Changes for v2:
- Use threaded irq as suggested by Hari and to fix possible "scheduling while atomic" issue
- Use oneshot irq as we do not want to enable the irq again until we clear our the messages
- Rebase on v6.9-rc3

Andrew Davis (13):
mailbox: omap: Remove unused omap_mbox_{enable,disable}_irq()
functions
mailbox: omap: Remove unused omap_mbox_request_channel() function
mailbox: omap: Move omap_mbox_irq_t into driver
mailbox: omap: Move fifo size check to point of use
mailbox: omap: Remove unneeded header omap-mailbox.h
mailbox: omap: Remove device class
mailbox: omap: Use devm_pm_runtime_enable() helper
mailbox: omap: Merge mailbox child node setup loops
mailbox: omap: Use function local struct mbox_controller
mailbox: omap: Use mbox_controller channel list directly
mailbox: omap: Remove mbox_chan_to_omap_mbox()
mailbox: omap: Reverse FIFO busy check logic
mailbox: omap: Remove kernel FIFO message queuing

 drivers/mailbox/Kconfig        |   9 -
 drivers/mailbox/omap-mailbox.c | 519 +++++++--------------------------
 include/linux/omap-mailbox.h   |  13 -
 3 files changed, 108 insertions(+), 433 deletions(-)
Signature · 1 line
2.39.2