Skip to content

clk: qcom: gpucc-sc8280xp: fix GX external supply lookup

Johan Hovold linux-arm-msm linux-clk lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5dt-bindings: clock: qcom: add SA8540P gpuccDocumentation/devicetree/bindings/clock/qcom,gpucc.yaml+1 -04 replies
2/5arm64: dts: qcom: sa8540p: use sa8540p gpucc compatiblearch/arm64/boot/dts/qcom/sa8540p.dtsi+2 -02 replies
3/5clk: qcom: gpucc-sc8280xp: make cc descriptor constdrivers/clk/qcom/gpucc-sc8280xp.c+1 -11 reply
4/5clk: qcom: gpucc-sc8280xp: fix GX external supply lookupdrivers/clk/qcom/gpucc-sc8280xp.c+35 -50 replies
5/5arm64: dts: qcom: sa8540p: drop fallback gpucc compatiblearch/arm64/boot/dts/qcom/sa8540p.dtsi+1 -10 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchKonrad Dybcio
1/5
2/5
3/5R-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] clk: qcom: gpucc-sc8280xp: fix GX external supply lookup

The SA8540P platform is closely related to SC8280XP but differs in that it uses an external supply for the GX power domain.

This series adds a new SA8540P GPU clock controller compatible which can be used to determine whether to look up the external supply.

This specifically avoids warnings such as:

	gpu_cc-sc8280xp 3d90000.clock-controller: supply vdd-gfx not found, using dummy regulator

on SC8280XP, which were introduced in 6.9-rc1.

Note that this also avoids triggering a potential deadlock on SC8280XP even if the underlying issue still remains for the derivative platforms like SA8540P and SA8295P that actually use the supply. [1]

Also note that this is a better alternative to simply making the external supply optional as that would suppress any warnings about missing supplies on platforms that actually require it. This series therefore supersedes [2].

Johan

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/

Johan Hovold (5):
dt-bindings: clock: qcom: add SA8540P gpucc
arm64: dts: qcom: sa8540p: use sa8540p gpucc compatible
clk: qcom: gpucc-sc8280xp: make cc descriptor const
clk: qcom: gpucc-sc8280xp: fix GX external supply lookup
arm64: dts: qcom: sa8540p: drop fallback gpucc compatible

 .../devicetree/bindings/clock/qcom,gpucc.yaml |  1 +
 arch/arm64/boot/dts/qcom/sa8540p.dtsi         |  2 +
 drivers/clk/qcom/gpucc-sc8280xp.c             | 42 ++++++++++++++++---
 3 files changed, 39 insertions(+), 6 deletions(-)
Signature · 1 line
2.43.0