Skip to content

kbuild: enable some -Wextra warnings by default

Arnd Bergmann amd-gfx bpf dri-devel intel-gfx intel-xe linux-arm-kernel linux-ide linux-kbuild linux-mm linux-modules linux-renesas-soc linux-scsi linux-trace-kernel lkml llvm netdev nouveau 1 version Applied

Status from this message: Applied to for-6.9-fixes with a fixed up patch title prefix ("ata: sata_sx4:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 of 12 patches 20 repliesApplied

10 of 12 patches are in this archive. The cover letter announces 12.

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/12kbuild: make -Woverride-init warnings more consistentdrivers/gpu/drm/amd/display/dc/dce110/Makefile drivers/gpu/drm/amd/display/dc/dce112/Makefile drivers/gpu/drm/amd/display/dc/dce120/Makefile +10 more+18 -238 replies
3/12kbuild: turn on -Wextra by defaultscripts/Makefile.extrawarn+4 -10 replies
4/12kbuild: remove redundant extra warning flagsscripts/Makefile.extrawarn+0 -160 replies
5/12firmware: dmi-id: add a release callback functiondrivers/firmware/dmi-id.c+6 -17 replies
6/12nouveau: fix function cast warningdrivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c+6 -12 replies
7/12cxlflash: fix function pointer cast warningsdrivers/scsi/cxlflash/lunmgt.c drivers/scsi/cxlflash/main.c drivers/scsi/cxlflash/superpipe.c +2 more+31 -390 replies
8/12x86: math-emu: fix function cast warningsarch/x86/math-emu/fpu_etc.c arch/x86/math-emu/fpu_trig.c arch/x86/math-emu/reg_constant.c+16 -60 replies
9/12kbuild: enable -Wcast-function-type-strict unconditionallyscripts/Makefile.extrawarn+0 -10 replies
10/12sata: sx4: fix pdc20621_get_from_dimm() on 64-bitdrivers/ata/sata_sx4.c+2 -43 replies
12/12kbuild: turn on -Wrestrict by defaultscripts/Makefile.extrawarn+0 -10 replies

Reviews trailers per patch

2 of 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSudip MukherjeeLuis ChamberlainSteven Rostedt (Google)Hamza MahfoozJani NikulaAndrew JefferyDamien Le MoalLinus Walleij
SeriesA-b R-b A-b
1/12A-b A-b A-b R-b
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12A-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v1 thread

Cover letter [PATCH 00/12] kbuild: enable some -Wextra warnings by default

From: Arnd Bergmann <[email protected]>

This is a follow-up on a couple of patch series I sent in the past, enabling -Wextra (aside from stuff that is explicitly disabled), -Wcast-function-pointer-strict and -Wrestrict.

I have tested these on 'defconfig' and 'allmodconfig' builds across all architectures, as well as many 'randconfig' builds on x86, arm and arm64. It would be nice to have all the Makefile.extrawarn changes in v6.10, hopefully with the driver fixes going in before that through the respective subsystem trees.

Arnd

Arnd Bergmann (12):
kbuild: make -Woverride-init warnings more consistent [v3] parport: mfc3: avoid empty-body warning
kbuild: turn on -Wextra by default
kbuild: remove redundant extra warning flags
firmware: dmi-id: add a release callback function
nouveau: fix function cast warning
cxlflash: fix function pointer cast warnings
x86: math-emu: fix function cast warnings
kbuild: enable -Wcast-function-type-strict unconditionally
sata: sx4: fix pdc20621_get_from_dimm() on 64-bit [v4] kallsyms: rework symbol lookup return codes
kbuild: turn on -Wrestrict by default

 arch/x86/math-emu/fpu_etc.c                   |  9 +++--
 arch/x86/math-emu/fpu_trig.c                  |  6 ++--
 arch/x86/math-emu/reg_constant.c              |  7 +++-
 drivers/ata/sata_sx4.c                        |  6 ++--
 drivers/firmware/dmi-id.c                     |  7 +++-
 .../gpu/drm/amd/display/dc/dce110/Makefile    |  2 +-
 .../gpu/drm/amd/display/dc/dce112/Makefile    |  2 +-
 .../gpu/drm/amd/display/dc/dce120/Makefile    |  2 +-
 drivers/gpu/drm/amd/display/dc/dce60/Makefile |  2 +-
 drivers/gpu/drm/amd/display/dc/dce80/Makefile |  2 +-
 drivers/gpu/drm/i915/Makefile                 |  6 ++--
 .../drm/nouveau/nvkm/subdev/bios/shadowof.c   |  7 +++-
 drivers/gpu/drm/xe/Makefile                   |  4 +--
 drivers/net/ethernet/renesas/sh_eth.c         |  2 +-
 drivers/parport/parport_mfc3.c                |  3 +-
 drivers/pinctrl/aspeed/Makefile               |  2 +-
 drivers/scsi/cxlflash/lunmgt.c                |  4 +--
 drivers/scsi/cxlflash/main.c                  | 14 ++++----
 drivers/scsi/cxlflash/superpipe.c             | 34 +++++++++----------
 drivers/scsi/cxlflash/superpipe.h             | 11 +++---
 drivers/scsi/cxlflash/vlun.c                  |  7 ++--
 fs/proc/Makefile                              |  2 +-
 include/linux/filter.h                        | 14 ++++----
 include/linux/ftrace.h                        |  6 ++--
 include/linux/module.h                        | 14 ++++----
 kernel/bpf/Makefile                           |  2 +-
 kernel/bpf/core.c                             |  7 ++--
 kernel/kallsyms.c                             | 23 +++++++------
 kernel/module/kallsyms.c                      | 26 +++++++-------
 kernel/trace/ftrace.c                         | 13 +++----
 mm/Makefile                                   |  3 +-
 scripts/Makefile.extrawarn                    | 33 ++++--------------
 32 files changed, 134 insertions(+), 148 deletions(-)
Signature · 40 lines
2.39.2

Cc: Bill Metzenthen <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: [email protected]
Cc: Damien Le Moal <[email protected]>
Cc: Jean Delvare <[email protected]>
Cc: Harry Wentland <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Sergey Shtylyov <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Sudip Mukherjee <[email protected]>
Cc: Andrew Jeffery <[email protected]>
Cc: "Manoj N. Kumar" <[email protected]>
Cc: "Martin K. Petersen" <[email protected]>
Cc: Alexei Starovoitov <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Luis Chamberlain <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Masahiro Yamada <[email protected]>
Cc: Nathan Chancellor <[email protected]>
Cc: Nicolas Schier <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]