Skip to content

RDMA/rxe: Various fixes and cleanups

Bob Pearson linux-rdma 3 versions – Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 2 repliesApplied
  2. v212 patches 0 repliesSuperseded
  3. v111 patches 4 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/12RDMA/rxe: Fix seg fault in rxe_comp_queue_pktdrivers/infiniband/sw/rxe/rxe_comp.c+3 -30 replies
2/12RDMA/rxe: Allow good work requests to be executeddrivers/infiniband/sw/rxe/rxe_verbs.c+5 -11 reply
3/12RDMA/rxe: Remove redundant scheduling of rxe_completerdrivers/infiniband/sw/rxe/rxe_verbs.c+0 -50 replies
4/12RDMA/rxe: Merge request and complete tasksdrivers/infiniband/sw/rxe/rxe_comp.c drivers/infiniband/sw/rxe/rxe_hw_counters.c drivers/infiniband/sw/rxe/rxe_hw_counters.h +7 more+63 -550 replies
5/12RDMA/rxe: Remove save/rollback_state in rxe_requesterdrivers/infiniband/sw/rxe/rxe_req.c+2 -380 replies
6/12RDMA/rxe: Don't schedule rxe_completer from rxe_requesterdrivers/infiniband/sw/rxe/rxe_net.c drivers/infiniband/sw/rxe/rxe_req.c+2 -130 replies
7/12RDMA/rxe: Don't call rxe_requester from rxe_completerdrivers/infiniband/sw/rxe/rxe_comp.c drivers/infiniband/sw/rxe/rxe_verbs.h+11 -70 replies
8/12RDMA/rxe: Don't call direct between tasksdrivers/infiniband/sw/rxe/rxe_comp.c drivers/infiniband/sw/rxe/rxe_resp.c drivers/infiniband/sw/rxe/rxe_verbs.c+4 -230 replies
9/12RDMA/rxe: Fix incorrect rxe_put in error pathdrivers/infiniband/sw/rxe/rxe_net.c+2 -100 replies
10/12RDMA/rxe: Make rxe_loopback match rxe_send behaviordrivers/infiniband/sw/rxe/rxe_net.c+6 -00 replies
11/12RDMA/rxe: Get rid of pkt resend on errdrivers/infiniband/sw/rxe/rxe_net.c drivers/infiniband/sw/rxe/rxe_req.c+3 -180 replies
12/12RDMA/rxe: Let destroy qp succeed with stuck packetdrivers/infiniband/sw/rxe/rxe_net.c drivers/infiniband/sw/rxe/rxe_qp.c+32 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH for-next v3 00/12] RDMA/rxe: Various fixes and cleanups

This series of patches is the result of high scale testing on a large HPC system with a large attached Lustre file system. Several errors were found which had not been previously seen at smaller scales. In this case up to 1600 QPs on 1024 compute nodes attached to about 100 flash storage nodes. Each patch has it's own description.

v3
Fixed an error in "Don't call rxe_requester from rxe_completer" Moved run_requester_again from a global to rxe_req_info.again. The control parameter has to be local to each qp.
v2
Minor edits to some of the commit messages.
Added a missing change to "Don't schedule rxe_completer...". Added a missing change to "Git rid of pkt resend on err". Added one additional commit.

Bob Pearson (12):
RDMA/rxe: Fix seg fault in rxe_comp_queue_pkt RDMA/rxe: Allow good work requests to be executed RDMA/rxe: Remove redundant scheduling of rxe_completer RDMA/rxe: Merge request and complete tasks RDMA/rxe: Remove save/rollback_state in rxe_requester RDMA/rxe: Don't schedule rxe_completer from rxe_requester RDMA/rxe: Don't call rxe_requester from rxe_completer RDMA/rxe: Don't call direct between tasks RDMA/rxe: Fix incorrect rxe_put in error path RDMA/rxe: Make rxe_loopback match rxe_send behavior RDMA/rxe: Get rid of pkt resend on err
RDMA/rxe: Let destroy qp succeed with stuck packet

 drivers/infiniband/sw/rxe/rxe_comp.c        | 32 ++++----
 drivers/infiniband/sw/rxe/rxe_hw_counters.c |  2 +-
 drivers/infiniband/sw/rxe/rxe_hw_counters.h |  2 +-
 drivers/infiniband/sw/rxe/rxe_loc.h         |  3 +-
 drivers/infiniband/sw/rxe/rxe_net.c         | 69 +++++++++--------
 drivers/infiniband/sw/rxe/rxe_qp.c          | 46 +++++-------
 drivers/infiniband/sw/rxe/rxe_req.c         | 82 ++++++---------------
 drivers/infiniband/sw/rxe/rxe_resp.c        | 14 +---
 drivers/infiniband/sw/rxe/rxe_verbs.c       | 17 ++---
 drivers/infiniband/sw/rxe/rxe_verbs.h       |  7 +-
 10 files changed, 111 insertions(+), 163 deletions(-)
Signature · 1 line
2.43.0