Skip to content

spi: pxa2xx: Drop linux/spi/pxa2xx_spi.h

Andy Shevchenko linux-arm-kernel linux-spi lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 12 repliesIn review
  2. v29 patches 9 repliesSuperseded
  3. v110 patches 20 repliesSuperseded

Changes in v3 from the cover letter

- added new patches that were previously sent separately ([email protected])
- extended cover letter a bit to explain that the replacement is not worse than the current approach
- v2: [email protected]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9spi: pxa2xx: Allow number of chip select pins to be read from propertydrivers/spi/spi-pxa2xx.c+5 -11 reply
2/9spi: pxa2xx: Provide num-cs for Sharp PDAs via device propertiesarch/arm/mach-pxa/spitz.c+18 -71 reply
3/9spi: pxa2xx: Move contents of linux/spi/pxa2xx_spi.h to a local onedrivers/spi/spi-pxa2xx-dma.c drivers/spi/spi-pxa2xx-pci.c drivers/spi/spi-pxa2xx.c +2 more+37 -531 reply
4/9spi: pxa2xx: Remove outdated documentationDocumentation/spi/pxa2xx.rst drivers/spi/Kconfig+1 -2101 reply
5/9spi: pxa2xx: Don't use "proxy" headersdrivers/spi/spi-pxa2xx-dma.c drivers/spi/spi-pxa2xx-pci.c drivers/spi/spi-pxa2xx.c +1 more+22 -71 reply
6/9spi: pxa2xx: Drop struct pxa2xx_spi_chipdrivers/spi/spi-pxa2xx-dma.c drivers/spi/spi-pxa2xx.c drivers/spi/spi-pxa2xx.h+2 -461 reply
7/9spi: pxa2xx: Remove DMA parameters from struct chip_datadrivers/spi/spi-pxa2xx-dma.c drivers/spi/spi-pxa2xx.c drivers/spi/spi-pxa2xx.h+9 -611 reply
8/9spi: pxa2xx: Remove timeout field from struct chip_datadrivers/spi/spi-pxa2xx.c drivers/spi/spi-pxa2xx.h+1 -41 reply
9/9spi: pxa2xx: Don't provide struct chip_data for othersdrivers/spi/spi-pxa2xx.c drivers/spi/spi-pxa2xx.h+8 -81 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchLinus Walleij
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9A-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/9] spi: pxa2xx: Drop linux/spi/pxa2xx_spi.h

As Arnd suggested we may drop linux/spi/pxa2xx_spi.h as most of its content is being used solely internally to SPI subsystem (PXA2xx drivers). Hence this refactoring series with the additional win of getting rid of legacy documentation.

Note, that we have the only user of a single plain integer field in the entire kernel for that. Switching to software nodes does not diminish any of type checking as we only pass an integer.

On top of that it includes the previously sent "spi: pxa2xx: Cleanup (part 2)" series that makes effort to clean up even more things.

Changelog v3:
- added new patches that were previously sent separately ([email protected])
- extended cover letter a bit to explain that the replacement is not worse than the current approach
- v2: [email protected]

Changelog v2:
- dropped applied patches
- added patch to amend dependencies (Mark)
- amended the second patch accordingly (Mark)
- elaborated purpose of the patch 6 in the commit message (Mark)
- v1: [email protected]

Cc Arnd Bergmann <[email protected]>

Andy Shevchenko (9):
spi: pxa2xx: Allow number of chip select pins to be read from property
spi: pxa2xx: Provide num-cs for Sharp PDAs via device properties
spi: pxa2xx: Move contents of linux/spi/pxa2xx_spi.h to a local one
spi: pxa2xx: Remove outdated documentation
spi: pxa2xx: Don't use "proxy" headers
spi: pxa2xx: Drop struct pxa2xx_spi_chip
spi: pxa2xx: Remove DMA parameters from struct chip_data
spi: pxa2xx: Remove timeout field from struct chip_data
spi: pxa2xx: Don't provide struct chip_data for others

 Documentation/spi/pxa2xx.rst   | 208 ---------------------------------
 arch/arm/mach-pxa/spitz.c      |  25 ++--
 drivers/spi/Kconfig            |   3 +-
 drivers/spi/spi-pxa2xx-dma.c   |  38 ++----
 drivers/spi/spi-pxa2xx-pci.c   |  10 +-
 drivers/spi/spi-pxa2xx.c       |  94 +++++----------
 drivers/spi/spi-pxa2xx.h       |  42 +++----
 include/linux/spi/pxa2xx_spi.h |  48 --------
 8 files changed, 87 insertions(+), 381 deletions(-)
 delete mode 100644 Documentation/spi/pxa2xx.rst
 delete mode 100644 include/linux/spi/pxa2xx_spi.h
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac