Skip to content

drm/i915: Implemnt vblank sycnhronized mbus joining changes

Ville Syrjala intel-gfx 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 0 repliesNew
  2. v113 patches 29 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/i915/cdclk: Fix CDCLK programming order when pipes are activedrivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_cdclk.h+8 -20 replies
2/14drm/i915/cdclk: Fix voltage_level programming edge casedrivers/gpu/drm/i915/display/intel_cdclk.c+27 -100 replies
3/14drm/i915/cdclk: Drop tgl/dg2 cdclk bump hacksdrivers/gpu/drm/i915/display/intel_cdclk.c+0 -190 replies
4/14drm/i915/cdclk: Indicate whether CDCLK change happens during pre or post plane updatedrivers/gpu/drm/i915/display/intel_cdclk.c+6 -130 replies
5/14drm/i915: Loop over all active pipes in intel_mbus_dbox_updatedrivers/gpu/drm/i915/display/skl_watermark.c+1 -60 replies
6/14drm/i915: Relocate intel_mbus_dbox_update()drivers/gpu/drm/i915/display/skl_watermark.c+83 -830 replies
7/14drm/i915: Extract intel_dbuf_mbus_join_update()drivers/gpu/drm/i915/display/skl_watermark.c+25 -120 replies
8/14drm/i915: Extract intel_dbuf_mdclk_min_tracker_update()drivers/gpu/drm/i915/display/skl_watermark.c+25 -180 replies
9/14drm/i915: Add debugs for mbus joining and dbuf ratio programmingdrivers/gpu/drm/i915/display/skl_watermark.c+9 -00 replies
10/14drm/i915: Use old mbus_join value when increasing CDCLKdrivers/gpu/drm/i915/display/intel_cdclk.c+6 -00 replies
11/14drm/i915: Use the correct mdclk/cdclk ratio in MBUS updatesdrivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_cdclk.h drivers/gpu/drm/i915/display/skl_watermark.c+20 -110 replies
12/14drm/i915: Implement vblank synchronized MBUS join changesdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/skl_watermark.c drivers/gpu/drm/i915/display/skl_watermark.h+92 -380 replies
13/14drm/i915: Use a plain old int for the cdclk/mdclk ratiodrivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_cdclk.h drivers/gpu/drm/i915/display/skl_watermark.c +1 more+13 -90 replies
14/14drm/i915: Optimize out redundant dbuf slice updatesdrivers/gpu/drm/i915/display/skl_watermark.c+18 -90 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchUma ShankarGustavo Sousa
1/14R-b R-b
2/14R-b
3/14R-b
4/14R-b R-b
5/14R-b
6/14R-b R-b
7/14R-b R-b
8/14R-b R-b
9/14R-b R-b
10/14R-b
11/14R-b
12/14R-b
13/14R-b R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/14] drm/i915: Implemnt vblank sycnhronized mbus joining changes

From: Ville Syrjälä <[email protected]>

Get rid of the full modeset requirement for changing mbus joining. Things got quite a bit more complicated than originally envisioned due to the dynamic cdclk/mdclk ratio. Sadly we have to do a fairly careful dance between the dbuf and cdclk code to make sure everything is programmed in the correct sequence.

Stan did the grunt work, but the sequence vs. cdclk updates was still not right so I finished that part. I also reorganized the code quite a bit to make the resulting patches more legible. And I tossed in more debugs and whatnot so we can actually observe what it's doing.

Quickly smoke tested on tgl and adl, and things seem pretty decent. Unfortunately I don't have a LNL on me right now so I haven't fully tested the mdclk/cdclk ratio changes on real hw, but I did hack my adl to pretend that the ratio changes with cdclk and double checked that the logs look sensible for all the combinations of cdclk increase/decrease and mbus join enable/disable. So should work (tm) on real hw too.

v2: Be more careful with the cd2x pipe select (Gustavo)
Split the intel_cdclk_is_decreasing_later() stuff to a separate patch (Gustavo)

Cc Gustavo Sousa <[email protected]>
Cc Uma Shankar <[email protected]>

Stanislav Lisovskiy (3):
drm/i915: Loop over all active pipes in intel_mbus_dbox_update drm/i915: Use old mbus_join value when increasing CDCLK drm/i915: Implement vblank synchronized MBUS join changes

Ville Syrjälä (11):
drm/i915/cdclk: Fix CDCLK programming order when pipes are active drm/i915/cdclk: Fix voltage_level programming edge case drm/i915/cdclk: Drop tgl/dg2 cdclk bump hacks drm/i915/cdclk: Indicate whether CDCLK change happens during pre or
post plane update
drm/i915: Relocate intel_mbus_dbox_update()
drm/i915: Extract intel_dbuf_mbus_join_update() drm/i915: Extract intel_dbuf_mdclk_min_tracker_update() drm/i915: Add debugs for mbus joining and dbuf ratio programming drm/i915: Use the correct mdclk/cdclk ratio in MBUS updates drm/i915: Use a plain old int for the cdclk/mdclk ratio drm/i915: Optimize out redundant dbuf slice updates

 drivers/gpu/drm/i915/display/intel_cdclk.c   |  99 +++---
 drivers/gpu/drm/i915/display/intel_cdclk.h   |   8 +-
 drivers/gpu/drm/i915/display/intel_display.c |   5 +-
 drivers/gpu/drm/i915/display/skl_watermark.c | 344 ++++++++++++-------
 drivers/gpu/drm/i915/display/skl_watermark.h |   9 +-
 5 files changed, 284 insertions(+), 181 deletions(-)
Signature · 1 line
2.43.2