drm/i915: Implemnt vblank sycnhronized mbus joining changes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest14 patches 0 repliesNew
- v113 patches 29 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | drm/i915/cdclk: Fix CDCLK programming order when pipes are activedrivers/ drivers/ | +8 | 0 replies | |
| 2/14 | drm/i915/cdclk: Fix voltage_level programming edge casedrivers/ | +27 | 0 replies | |
| 3/14 | drm/i915/cdclk: Drop tgl/dg2 cdclk bump hacksdrivers/ | +0 | 0 replies | |
| 4/14 | drm/i915/cdclk: Indicate whether CDCLK change happens during pre or post plane updatedrivers/ | +6 | 0 replies | |
| 5/14 | drm/i915: Loop over all active pipes in intel_mbus_dbox_updatedrivers/ | +1 | 0 replies | |
| 6/14 | drm/i915: Relocate intel_mbus_dbox_update()drivers/ | +83 | 0 replies | |
| 7/14 | drm/i915: Extract intel_dbuf_mbus_join_update()drivers/ | +25 | 0 replies | |
| 8/14 | drm/i915: Extract intel_dbuf_mdclk_min_tracker_update()drivers/ | +25 | 0 replies | |
| 9/14 | drm/i915: Add debugs for mbus joining and dbuf ratio programmingdrivers/ | +9 | 0 replies | |
| 10/14 | drm/i915: Use old mbus_join value when increasing CDCLKdrivers/ | +6 | 0 replies | |
| 11/14 | drm/i915: Use the correct mdclk/cdclk ratio in MBUS updatesdrivers/ drivers/ drivers/ | +20 | 0 replies | |
| 12/14 | drm/i915: Implement vblank synchronized MBUS join changesdrivers/ drivers/ drivers/ | +92 | 0 replies | |
| 13/14 | drm/i915: Use a plain old int for the cdclk/mdclk ratiodrivers/ drivers/ drivers/ +1 more | +13 | 0 replies | |
| 14/14 | drm/i915: Optimize out redundant dbuf slice updatesdrivers/ | +18 | 0 replies |
Reviews trailers per patch
All 14 patches have a Reviewed-by or Acked-by.
| Patch | Uma Shankar | Gustavo Sousa |
|---|---|---|
| 1/14 | R-b | R-b |
| 2/14 | R-b | |
| 3/14 | R-b | |
| 4/14 | R-b | R-b |
| 5/14 | R-b | |
| 6/14 | R-b | R-b |
| 7/14 | R-b | R-b |
| 8/14 | R-b | R-b |
| 9/14 | R-b | R-b |
| 10/14 | R-b | |
| 11/14 | R-b | |
| 12/14 | R-b | |
| 13/14 | R-b | R-b |
| 14/14 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/14] drm/i915: Implemnt vblank sycnhronized mbus joining changes
From: Ville Syrjälä <[email protected]>
Get rid of the full modeset requirement for changing mbus joining. Things got quite a bit more complicated than originally envisioned due to the dynamic cdclk/mdclk ratio. Sadly we have to do a fairly careful dance between the dbuf and cdclk code to make sure everything is programmed in the correct sequence.
Stan did the grunt work, but the sequence vs. cdclk updates was still not right so I finished that part. I also reorganized the code quite a bit to make the resulting patches more legible. And I tossed in more debugs and whatnot so we can actually observe what it's doing.
Quickly smoke tested on tgl and adl, and things seem pretty decent. Unfortunately I don't have a LNL on me right now so I haven't fully tested the mdclk/cdclk ratio changes on real hw, but I did hack my adl to pretend that the ratio changes with cdclk and double checked that the logs look sensible for all the combinations of cdclk increase/decrease and mbus join enable/disable. So should work (tm) on real hw too.
v2: Be more careful with the cd2x pipe select (Gustavo)
Split the intel_cdclk_is_decreasing_later() stuff to a separate patch (Gustavo)
Stanislav Lisovskiy (3):
drm/i915: Loop over all active pipes in intel_mbus_dbox_update drm/i915: Use old mbus_join value when increasing CDCLK drm/i915: Implement vblank synchronized MBUS join changes
Ville Syrjälä (11):
drm/i915/cdclk: Fix CDCLK programming order when pipes are active drm/i915/cdclk: Fix voltage_level programming edge case drm/i915/cdclk: Drop tgl/dg2 cdclk bump hacks drm/i915/cdclk: Indicate whether CDCLK change happens during pre or
post plane update
drm/i915: Relocate intel_mbus_dbox_update()
drm/i915: Extract intel_dbuf_mbus_join_update() drm/i915: Extract intel_dbuf_mdclk_min_tracker_update() drm/i915: Add debugs for mbus joining and dbuf ratio programming drm/i915: Use the correct mdclk/cdclk ratio in MBUS updates drm/i915: Use a plain old int for the cdclk/mdclk ratio drm/i915: Optimize out redundant dbuf slice updates
drivers/gpu/drm/i915/display/intel_cdclk.c | 99 +++--- drivers/gpu/drm/i915/display/intel_cdclk.h | 8 +- drivers/gpu/drm/i915/display/intel_display.c | 5 +- drivers/gpu/drm/i915/display/skl_watermark.c | 344 ++++++++++++------- drivers/gpu/drm/i915/display/skl_watermark.h | 9 +- 5 files changed, 284 insertions(+), 181 deletions(-)
Signature · 1 line
2.43.2