vvfat: Fix write bugs for large files and add iotests
Status from this message: Thanks, applied to the block branch (with patch 4 changed as indicated
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest5 patches 3 repliesApplied
- v55 patches 18 repliesSuperseded
- v44 patches 8 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 6 patches | 4 replies | Superseded | |
| v2 | 5 patches | 1 reply | Superseded | |
| v1 | 3 patches | 3 replies | Superseded |
Changes in v6 from the cover letter
- small fixes and code improvements when switching between active vfat mappings
- small fixes and code improvements for the fa16.py driver used for iotests
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | vvfat: Fix bug in writing to middle of fileblock/ | +2 | 0 replies | |
| 2/5 | vvfat: Fix usage of `info.file.offset`block/ | +7 | 0 replies | |
| 3/5 | vvfat: Fix wrong checks for cluster mappings invariantblock/ | +2 | 0 replies | |
| 4/5 | vvfat: Fix reading files with non-continuous clustersblock/ | +6 | 2 replies | |
| 5/5 | iotests: Add `vvfat` teststests/ tests/ tests/ +2 more | +1140 | 0 replies |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Kevin Wolf |
|---|---|
| 1/5 | R-b T-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | |
| 5/5 | R-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/5] vvfat: Fix write bugs for large files and add iotests
These patches fix some bugs found when modifying files in vvfat. First, there was a bug when writing to the cluster 2 or above of a file, it will copy the cluster before it instead, so, when writing to cluster=2, the content of cluster=1 will be copied into disk instead in its place.
Another issue was modifying the clusters of a file and adding new clusters, this showed 2 issues:
- If the new cluster is not immediately after the last cluster, it will cause issues when reading from this file in the future.
- Generally, the usage of info.file.offset was incorrect, and the system would crash on abort() when the file is modified and a new cluster was added.
Also, added some iotests for vvfat, covering the this fix and also general behavior such as reading, writing, and creating files on the filesystem. Including tests for reading/writing the first cluster which
would pass even before this patch.
v6:
- small fixes and code improvements when switching between active vfat mappings
- small fixes and code improvements for the fa16.py driver used for iotests
v5:
- Fix a bug in reading non-contiguous clusters in vvfat for more than 2 mappings.
- Added a test for adding more clusters where they are non-contiguous and result in 3 mappings (for the above fix).
- Split PATCH 2/4 into 2 patches and a better fix for the abort issue (now in PATCH 3/5).
- Other fixes and improvements in fat16.py module used for iotests.
v4:
Applied some suggestions from Kevin Wolf <[email protected]>:
- Fixed code formatting by following the coding style in scripts/checkpatch.pl
- Reduced changes related to iotests by setting vvfat format as non-generic.
- Added another test to cover the fix done in PATCH 2/4 and PATCH 3/4 for handling reading/writing files with non-continuous clusters.
v3:
Added test for creating new files in vvfat.
v2:
Added iotests for vvfat driver along with a simple fat16 module to run the tests.
v1:
https://patchew.org/QEMU/[email protected]/
Fix the issue of writing to the middle of the file in vvfat
Amjad Alsharafi (5):
vvfat: Fix bug in writing to middle of file
vvfat: Fix usage of info.file.offset
vvfat: Fix wrong checks for cluster mappings invariant
vvfat: Fix reading files with non-continuous clusters
iotests: Add vvfat tests
block/vvfat.c | 34 +- tests/qemu-iotests/check | 2 +- tests/qemu-iotests/fat16.py | 675 +++++++++++++++++++++++++++++ tests/qemu-iotests/testenv.py | 2 +- tests/qemu-iotests/tests/vvfat | 458 +++++++++++++++++++ tests/qemu-iotests/tests/vvfat.out | 5 + 6 files changed, 1157 insertions(+), 19 deletions(-) create mode 100644 tests/qemu-iotests/fat16.py create mode 100755 tests/qemu-iotests/tests/vvfat create mode 100755 tests/qemu-iotests/tests/vvfat.out
Signature · 1 line
2.45.2