Skip to content

Drop old distros, bump glib and switch to glib URI parsing code

Thomas Huth qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 3 repliesIn review
  2. v213 patches 20 repliesSuperseded
  3. v19 patches 18 repliesSuperseded

Changes in v3 from the cover letter

- Added Reviewed-bys
- Updated many patch descriptions according to the review feedback in v2
- Change "Illegal" in warning message to "Invalid"
- Removed "." at the end of a warn_report string

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13tests: Remove Ubuntu 20.04 containertests/docker/dockerfiles/ubuntu2004.docker tests/lcitool/refresh+0 -1581 reply
2/13tests/lcitool/libvirt-ci: Update to the latest master branchtests/lcitool/libvirt-ci+1 -10 replies
3/13tests/docker/dockerfiles: Run lcitool-refresh after the lcitool updatetests/docker/dockerfiles/alpine.docker tests/docker/dockerfiles/centos8.docker tests/docker/dockerfiles/debian-amd64-cross.docker +14 more+29 -120 replies
4/13tests: Update our CI to use CentOS Stream 9 instead of 8.gitlab-ci.d/buildtest.yml .gitlab-ci.d/container-core.yml tests/docker/dockerfiles/centos9.docker +3 more+26 -541 reply
5/13.travis.yml: Update the jobs to Ubuntu 22.04.travis.yml+3 -100 replies
6/13ci: move external build environment setups to CentOS Stream 9scripts/ci/org.centos/stream/9/build-environment.yml scripts/ci/org.centos/stream/9/x86_64/configure scripts/ci/org.centos/stream/9/x86_64/test-avocado +1 more+34 -450 replies
7/13Bump minimum glib version to v2.66include/glib-compat.h meson.build qga/commands-posix-ssh.c+5 -420 replies
8/13Remove glib compatibility code that is not required anymoreqga/commands-posix-ssh.c util/error-report.c+0 -180 replies
9/13block/gluster: Use URI parsing code from glibblock/gluster.c+35 -361 reply
10/13block/nbd: Use URI parsing code from glibblock/nbd.c+37 -390 replies
11/13block/nfs: Use URI parsing code from glibblock/nfs.c+54 -560 replies
12/13block/ssh: Use URI parsing code from glibblock/ssh.c+40 -350 replies
13/13util/uri: Remove the old URI parsing codeinclude/qemu/uri.h util/meson.build util/uri.c+1 -15660 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéDaniel P. BerrangéRichard W.M. JonesEric BlakeThomas Huth
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b R-b
7/13R-b
8/13R-b
9/13R-b R-b
10/13R-b R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/13] Drop old distros, bump glib and switch to glib URI parsing code

In the QEMU 9.1 development cycle, we can drop the support for Ubuntu 20.04 and CentOS 8 since the following major versions of these distributions are available since 2 years already.

This allows us to bump the minimum version of glib to 2.66 which comes with a nice set of URI parsing functions. By switching to these parsing functions, we can finally drop our own URI parsing code in util/uri.c.

NB: We also need to update some of the custom runners in our CI environment first (since they still use Ubuntu 20.04).

v3:
- Added Reviewed-bys
- Updated many patch descriptions according to the review feedback in v2
- Change "Illegal" in warning message to "Invalid"
- Removed "." at the end of a warn_report string

v2:
- Added Paolo's patch to bump the external CI runners
- Added patch to drop more glib compatibility hunks
- Use g_autoptr() in the URI patches for simplification
- Don't allow port 0 in the URIs

Paolo Bonzini (1):
ci: move external build environment setups to CentOS Stream 9

Thomas Huth (12):
tests: Remove Ubuntu 20.04 container tests/lcitool/libvirt-ci: Update to the latest master branch tests/docker/dockerfiles: Run lcitool-refresh after the lcitool update
tests: Update our CI to use CentOS Stream 9 instead of 8 .travis.yml: Update the jobs to Ubuntu 22.04
Bump minimum glib version to v2.66
Remove glib compatibility code that is not required anymore block/gluster: Use URI parsing code from glib
block/nbd: Use URI parsing code from glib
block/nfs: Use URI parsing code from glib
block/ssh: Use URI parsing code from glib
util/uri: Remove the old URI parsing code

 meson.build                                   |   16 +-
 include/glib-compat.h                         |   27 +-
 include/qemu/uri.h                            |   99 --
 block/gluster.c                               |   71 +-
 block/nbd.c                                   |   76 +-
 block/nfs.c                                   |  110 +-
 block/ssh.c                                   |   75 +-
 qga/commands-posix-ssh.c                      |   12 +-
 util/error-report.c                           |   10 -
 util/uri.c                                    | 1466 -----------------
 .gitlab-ci.d/buildtest.yml                    |   16 +-
 .gitlab-ci.d/container-core.yml               |    4 +-
 .travis.yml                                   |   13 +-
 .../stream/{8 => 9}/build-environment.yml     |   31 +-
 .../stream/{8 => 9}/x86_64/configure          |    4 +-
 .../stream/{8 => 9}/x86_64/test-avocado       |    0
 scripts/ci/setup/build-environment.yml        |   44 +-
 tests/docker/dockerfiles/alpine.docker        |    3 +-
 .../{centos8.docker => centos9.docker}        |   35 +-
 .../dockerfiles/debian-amd64-cross.docker     |    3 +-
 .../dockerfiles/debian-arm64-cross.docker     |    3 +-
 .../dockerfiles/debian-armel-cross.docker     |    3 +-
 .../dockerfiles/debian-armhf-cross.docker     |    3 +-
 .../dockerfiles/debian-i686-cross.docker      |    3 +-
 .../dockerfiles/debian-mips64el-cross.docker  |    3 +-
 .../dockerfiles/debian-mipsel-cross.docker    |    3 +-
 .../dockerfiles/debian-ppc64el-cross.docker   |    3 +-
 .../dockerfiles/debian-riscv64-cross.docker   |    3 +-
 .../dockerfiles/debian-s390x-cross.docker     |    3 +-
 tests/docker/dockerfiles/debian.docker        |    1 +
 .../dockerfiles/fedora-win64-cross.docker     |    3 +-
 tests/docker/dockerfiles/fedora.docker        |    1 +
 tests/docker/dockerfiles/opensuse-leap.docker |    1 +
 tests/docker/dockerfiles/ubuntu2004.docker    |  157 --
 tests/docker/dockerfiles/ubuntu2204.docker    |    1 +
 tests/lcitool/libvirt-ci                      |    2 +-
 tests/lcitool/mappings.yml                    |   20 -
 tests/lcitool/refresh                         |    3 +-
 tests/vm/centos                               |    4 +-
 util/meson.build                              |    2 +-
 40 files changed, 265 insertions(+), 2072 deletions(-)
 delete mode 100644 include/qemu/uri.h
 delete mode 100644 util/uri.c
 rename scripts/ci/org.centos/stream/{8 => 9}/build-environment.yml (75%)
 rename scripts/ci/org.centos/stream/{8 => 9}/x86_64/configure (98%)
 rename scripts/ci/org.centos/stream/{8 => 9}/x86_64/test-avocado (100%)
 rename tests/docker/dockerfiles/{centos8.docker => centos9.docker} (82%)
 delete mode 100644 tests/docker/dockerfiles/ubuntu2004.docker
Signature · 1 line
2.44.0