Skip to content

quota-related e2fsck fixes and tests

Luis Henriques (SUSE) linux-ext4 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyApplied
  2. v24 patches 3 repliesSuperseded
  3. v14 patches 5 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4e2fsck: update quota accounting after directory optimizatione2fsck/rehash.c+21 -60 replies
2/4e2fsck: update quota when deallocating a bad inodee2fsck/pass2.c+32 -110 replies
3/4tests: new test to check quota after directory optimizationtests/f_quota_shrinkdir/expect.1 tests/f_quota_shrinkdir/expect.2 tests/f_quota_shrinkdir/image.gz +1 more+26 -00 replies
4/4tests: new test to check quota after a bad inode deallocationtests/f_quota_deallocate_inode/expect.1 tests/f_quota_deallocate_inode/expect.2 tests/f_quota_deallocate_inode/image.gz +1 more+26 -00 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndreas Dilger
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH e2fsprogs v3 0/4] quota-related e2fsck fixes and tests

Hi!

Changes since v2:

Added deallocate_inode() documentation, as suggested by Andreas Dilger (and using text he provided).

And, for reference, here's the cover-letter from v2:

I'm (re)sending two fixes to e2fsck that are related with quota handling. The fixes are the first two patches, the other two are test cases for these fixes.

As I mentioned in v1, the issues were found using fstests ext4/014 and ext4/019. And the only thing in this series that changed from v1 was the first test ("tests: new test to check quota after directory optimization"), which is now using a much simplified version of the testcase.

Note that, since the first two patches didn't change, they have already a

which I'm not including in the patches themselves. Should I? Or is that better left for the maintainer (eventually) applying them?

Cheers,

Signature · 28 lines
Luis


Luis Henriques (SUSE) (4):
  e2fsck: update quota accounting after directory optimization
  e2fsck: update quota when deallocating a bad inode
  tests: new test to check quota after directory optimization
  tests: new test to check quota after a bad inode deallocation

 e2fsck/pass2.c                          |  43 ++++++++++++++++++------
 e2fsck/rehash.c                         |  27 +++++++++++----
 tests/f_quota_deallocate_inode/expect.1 |  18 ++++++++++
 tests/f_quota_deallocate_inode/expect.2 |   7 ++++
 tests/f_quota_deallocate_inode/image.gz | Bin 0 -> 11594 bytes
 tests/f_quota_deallocate_inode/name     |   1 +
 tests/f_quota_shrinkdir/expect.1        |  18 ++++++++++
 tests/f_quota_shrinkdir/expect.2        |   7 ++++
 tests/f_quota_shrinkdir/image.gz        | Bin 0 -> 10761 bytes
 tests/f_quota_shrinkdir/name            |   1 +
 10 files changed, 105 insertions(+), 17 deletions(-)
 create mode 100644 tests/f_quota_deallocate_inode/expect.1
 create mode 100644 tests/f_quota_deallocate_inode/expect.2
 create mode 100644 tests/f_quota_deallocate_inode/image.gz
 create mode 100644 tests/f_quota_deallocate_inode/name
 create mode 100644 tests/f_quota_shrinkdir/expect.1
 create mode 100644 tests/f_quota_shrinkdir/expect.2
 create mode 100644 tests/f_quota_shrinkdir/image.gz
 create mode 100644 tests/f_quota_shrinkdir/name