Skip to content

Rework work queue usage

Matthew Brost intel-xe 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/xe: Use ordered wq for preempt fence waitingdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device_types.h drivers/gpu/drm/xe/xe_preempt_fence.c+14 -22 replies
2/3drm/xe: Use device, gt ordered work queues for resource cleanupdrivers/gpu/drm/xe/xe_device_types.h drivers/gpu/drm/xe/xe_execlist.c drivers/gpu/drm/xe/xe_gt_types.h +2 more+12 -60 replies
3/3drm/xe: Use ordered WQ for TLB invalidation fencesdrivers/gpu/drm/xe/xe_pt.c+1 -10 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchLucas De Marchi
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Rework work queue usage

Avoid sleeping or grabbing locks in work queues shared with the system. Recent changes to work queues [1] have exposed deadlocks [2] in Xe.

I believe only patch #1 is required to unblock CI in 6.9rc1 [2] but likely all patches should be included in stable kernels.

Matt

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://intel-gfx-ci.01.org/tree/intel-xe/xe-984-093d82c02921344d8d400989af156aaf79b9d961/bat-adlp-7/igt_runner0.txt

Matthew Brost (3):
drm/xe: Use ordered wq for preempt fence waiting drm/xe: Use device, gt ordered work queues for resource cleanup drm/xe: Use ordered WQ for TLB invalidation fences

 drivers/gpu/drm/xe/xe_device.c        | 11 ++++++++++-
 drivers/gpu/drm/xe/xe_device_types.h  |  8 +++++++-
 drivers/gpu/drm/xe/xe_execlist.c      |  2 +-
 drivers/gpu/drm/xe/xe_gt_types.h      |  5 ++++-
 drivers/gpu/drm/xe/xe_guc_submit.c    |  2 +-
 drivers/gpu/drm/xe/xe_preempt_fence.c |  2 +-
 drivers/gpu/drm/xe/xe_pt.c            |  2 +-
 drivers/gpu/drm/xe/xe_vm.c            |  4 ++--
 8 files changed, 27 insertions(+), 9 deletions(-)
Signature · 1 line
2.34.1