Skip to content

Cleanup and improve MSG_RING performance

Jens Axboe io-uring 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyIn review
  2. v23 patches 3 repliesSuperseded
  3. v13 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- Ensure fd install locking is correct

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4io_uring: add remote task_work execution helperio_uring/io_uring.c io_uring/io_uring.h+24 -81 reply
2/4io_uring/msg_ring: cleanup posting to IOPOLL vs !IOPOLL ringio_uring/msg_ring.c+4 -60 replies
3/4io_uring/msg_ring: split fd installing into a helperio_uring/msg_ring.c+18 -80 replies
4/4io_uring/msg_ring: improve handling of target CQE postingio_uring/msg_ring.c+7 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCHSET v3 0/4] Cleanup and improve MSG_RING performance

Hi,

Hi,

MSG_RING rolls its own task_work handling, which there's really no need for. Rather, it should use the generic io_uring infrastructure for this.

Add a helper for remote execution, and switch over MSG_RING to use it. This both cleans up the code, and improves performance of this opcode considerably.

 io_uring/io_uring.c | 30 ++++++++++++++++------
 io_uring/io_uring.h |  2 ++
 io_uring/msg_ring.c | 62 +++++++++++++++++++++------------------------
 3 files changed, 53 insertions(+), 41 deletions(-)

Changes since v2:
- Ensure fd install locking is correct

Signature · 1 line
Jens Axboe