Skip to content

package/pppd: fix pppd startup with upstream patches

Alexis Lothoré via buildroot buildroot 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- re-generated correctly patches to preserve original author
- added missing SoB

[1] https://github.com/ppp-project/ppp/issues/419
[2] https://github.com/ppp-project/ppp/issues/460

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3package/pppd: revert lock pathpackage/pppd/0005-Revert-lock-path-to-var-lock-435.patch+66 -00 replies
2/3package/pppd: add mkdir recursivepackage/pppd/0006-utils-add-mkdir_recursive.patch+294 -00 replies
3/3package/pppd: create rundir when it is missingpackage/pppd/0007-try-to-create-rundir-if-missing.patch+52 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Buildroot] [PATCH v2 0/3] package/pppd: fix pppd startup with upstream patches

Hello,
pppd fails to start on a systems with buildroot 2024.02.x because of missing pppd directory in /var/run. There are some logs hinting at this issue:
Warning: couldn't open ppp database /var/run/pppd/pppd2.tdb
Can't create lock file /var/run/pppd/lock/LCK..ppp-tty-fifo1: No such file or directory Can't create lock file /var/run/pppd/lock/LCK..ppp-tty-fifo1: No such file or directory Can't create lock file /var/run/pppd/lock/LCK..ppp-tty-fifo1: No such file or directory Can't create lock file /var/run/pppd/lock/LCK..ppp-tty-fifo1: No such file or directory Can't create lock file /var/run/pppd/lock/LCK..ppp-tty-fifo1: No such file or directory Can't create lock file /var/run/pppd/lock/LCK..ppp-tty-fifo1: No such file or directory Can't create lock file /var/run/pppd/lock/LCK..ppp-tty-fifo1: No such file or directory

The issue has already been detected and fixed upstream (see [1]) and is expected to be released on a v2.5.1, but this release seems to be stalled for now (see [2]). A mere bump of the package is then not currently possible, so I am proposing a pick of the 3 relevant patches to fix this startup issue, both for master and 2024.02.x

Tested on ARM Cortex A9

Changes in v2:
- re-generated correctly patches to preserve original author
- added missing SoB

[1] https://github.com/ppp-project/ppp/issues/419
[2] https://github.com/ppp-project/ppp/issues/460

Alexis Lothoré (3):
package/pppd: revert lock path
package/pppd: add mkdir recursive
package/pppd: create rundir when it is missing

 ...005-Revert-lock-path-to-var-lock-435.patch |  66 ++++
 .../pppd/0006-utils-add-mkdir_recursive.patch | 294 ++++++++++++++++++
 ...0007-try-to-create-rundir-if-missing.patch |  52 ++++
 3 files changed, 412 insertions(+)
 create mode 100644 package/pppd/0005-Revert-lock-path-to-var-lock-435.patch
 create mode 100644 package/pppd/0006-utils-add-mkdir_recursive.patch
 create mode 100644 package/pppd/0007-try-to-create-rundir-if-missing.patch
Signature · 6 lines
2.44.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot