Multishot read tweaks
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | io_uring/rw: don't allow multishot reads without NOWAIT supportio_uring/ | +8 | 0 replies | |
| 2/2 | io_uring: disable io-wq execution of multishot NOWAIT requestsio_uring/ | +9 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCHSET 0/2] Multishot read tweaks
Hi,
We can't properly support multishot reads unless one of the following conditions are true:
1) The file supports proper FMODE_NOWAIT
2) Barring proper FMODE_NOWAIT support, the file must be opened in non-blocking O_NONBLOCK mode
Without either one of those, non-blocking retries cannot be attempted. And without that, it's pointless to support multishot reads.
If this is attempted, fall back to singleshot mode. This will properly do the initial CQE posting, but will not set IORING_CQE_F_MORE as we can't reliably perform the retries that multishot requires.
io_uring/io_uring.c | 13 +++++++++---- io_uring/rw.c | 9 ++++++++- 2 files changed, 17 insertions(+), 5 deletions(-)
Signature · 1 line
Jens Axboe