Skip to content

Multishot read tweaks

Jens Axboe io-uring stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2io_uring/rw: don't allow multishot reads without NOWAIT supportio_uring/rw.c+8 -10 replies
2/2io_uring: disable io-wq execution of multishot NOWAIT requestsio_uring/io_uring.c+9 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHSET 0/2] Multishot read tweaks

Hi,

We can't properly support multishot reads unless one of the following conditions are true:

1) The file supports proper FMODE_NOWAIT
2) Barring proper FMODE_NOWAIT support, the file must be opened in non-blocking O_NONBLOCK mode

Without either one of those, non-blocking retries cannot be attempted. And without that, it's pointless to support multishot reads.

If this is attempted, fall back to singleshot mode. This will properly do the initial CQE posting, but will not set IORING_CQE_F_MORE as we can't reliably perform the retries that multishot requires.

 io_uring/io_uring.c | 13 +++++++++----
 io_uring/rw.c       |  9 ++++++++-
 2 files changed, 17 insertions(+), 5 deletions(-)
Signature · 1 line
Jens Axboe