Skip to content

media: i2c: Add imx283 camera sensor driver

Umang Jain linux-arm-kernel linux-devicetree linux-media lkml llvm 2 versions In review

Get series with b4
b4 am 20240402-kernel-name-extraversion-v4-0-fb776893e4ec@ideasonboard.com change-id 20240402-kernel-name-extraversion-2b08d441e08c

Versions newest first

  1. v4 Latest2 patches 2 repliesIn review
  2. v13 patches 3 repliesSuperseded

Changes in v4 from the cover letter

- fix 32-bit build error around u64 divisions (use do_div)
- Fix hmax default and minimum values

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2media: dt-bindings: media: Add bindings for IMX283Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml MAINTAINERS+115 -00 replies
2/2media: i2c: Add imx283 camera sensor driverMAINTAINERS drivers/media/i2c/Kconfig drivers/media/i2c/Makefile +1 more+1617 -02 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchRob HerringLaurent Pinchart
1/2R-b R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] media: i2c: Add imx283 camera sensor driver

Add a v4l2 subdevice driver for the Sony IMX283 image sensor.

The IMX283 is a 20MP Diagonal 15.86 mm (Type 1) CMOS Image Sensor with Square Pixel for Color Cameras.

The following features are supported:
- Manual exposure an gain control support
- vblank/hblank/link freq control support
- Test pattern support control
- Arbitrary horizontal and vertical cropping
- Supported resolution:
- 5472x3648 @ 20fps (SRGGB12)
- 5472x3648 @ 25fps (SRGGB10)
- 2736x1824 @ 50fps (SRGGB12)

The driver is tested on mainline branch v6.8-rc2 on IMX8MP Debix-SOM-A. Additional testing has been done on RPi5 with the downstream BSP.

Changes in v4:
- fix 32-bit build error around u64 divisions (use do_div)
- Fix hmax default and minimum values

Changes in v3:
- fix headers includes
- Improve #define(s) readability
- Drop __func__ from error logs
- Use HZ_PER_MHZ instead of MEGA
- mdsel* variables should be u8
- Use container_of_const() instead of container_of()
- Use clamp() used of clamp_t variant
- Use streams API imx283_{enable|disable}_streams (**NOTE**)
- Properly fix PM runtime handling
(pm_ptr(), DEFINE_RUNTIME_DEV_PM_OPS,
imx283_runtime_suspend, imx283_runtime_resume)
- Fix format modifiers, signed-ness at various places

changes in v2 (summary):
- Use u32 wherever possible
- Use MEGA macro instead of self defined MHZ() macro
- Properly refine regs using CCI
- Drop tracking of current mode. Shifted to infer from active state directly. (Laurent's review)
- Cont. from above: Pass the struct imx283_mode to functions whereever required.
- Remove unused comments
- Remove custom mutex. Use control handler one instead.
- Drop imx283_reset_colorspace() and inline
- Set colorspace field properly (drop _DEFAULTS)
- Use __maybe_unused for imx283_power_on() and imx283_power_off()
- Store controls v4l2_ctrl handles for those required, not all.
- Drop imx283_free_controls(). Use v4l2_ctrl_handler_free
- fix reset-gpios handling and add it to DT schema
- fix data-lanes property in DT schema
- fix IMX283 Kconfig
- Remove unused macros
- Alphabetical case consistency

---
Kieran Bingham (1):
media: i2c: Add imx283 camera sensor driver

Umang Jain (1):
media: dt-bindings: media: Add bindings for IMX283

 .../devicetree/bindings/media/i2c/sony,imx283.yaml |  107 ++
 MAINTAINERS                                        |    9 +
 drivers/media/i2c/Kconfig                          |   10 +
 drivers/media/i2c/Makefile                         |    1 +
 drivers/media/i2c/imx283.c                         | 1605 ++++++++++++++++++++
 5 files changed, 1732 insertions(+)

---
base-commit: 54ee11761885407056f4ca60309739e2db6b02dc
change-id: 20240402-kernel-name-extraversion-2b08d441e08c

Best regards,

Signature · 1 line
Umang Jain <[email protected]>