Skip to content

asus-wmi: add new features, clean up, fixes

Luke D. Jones lkml platform-driver-x86 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 2 repliesIn review
  2. v39 patches 4 repliesSuperseded
  3. v29 patches 14 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v19 patches0 repliesSuperseded

Changelog from the cover letter · 22 lines

- V1
- Mini-LED: use asus_wmi_get_devstate() and not asus_wmi_get_devstate_simple()
- Fix dates in Documentation/ABI/testing/sysfs-platform-asus-wmi
- Remove <name>_available bools and rely on devid for:
- gpu_mux
- mini_led
- kbd_rgb (TUF RGB LED)
- V2
- Fix formating on select if/else blocks shown by checkpatch.pl
- V3
- mini-led patch:
- Add error handling
- Add defines inplace of "magic" numbers
- Remove outdated comment
- Clarify existing comments
- post-sound patch:
- Add missing newline
- min-default-ppt patch
Use %u instead of %d in sysfs_emit()
- V4
- mini-led patch:
- Minor formatting cleanup

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9platform/x86: asus-wmi: add support for 2024 ROG Mini-LEDDocumentation/ABI/testing/sysfs-platform-asus-wmi drivers/platform/x86/asus-wmi.c include/linux/platform_data/x86/asus-wmi.h+95 -102 replies
2/9platform/x86: asus-wmi: add support for Vivobook GPU MUXdrivers/platform/x86/asus-wmi.c include/linux/platform_data/x86/asus-wmi.h+14 -90 replies
3/9platform/x86: asus-wmi: add support variant of TUF RGBdrivers/platform/x86/asus-wmi.c include/linux/platform_data/x86/asus-wmi.h+10 -40 replies
4/9platform/x86: asus-wmi: support toggling POST soundDocumentation/ABI/testing/sysfs-platform-asus-wmi drivers/platform/x86/asus-wmi.c include/linux/platform_data/x86/asus-wmi.h+63 -00 replies
5/9platform/x86: asus-wmi: store a min default for ppt optionsdrivers/platform/x86/asus-wmi.c+99 -280 replies
6/9platform/x86: asus-wmi: adjust formatting of ppt-<name>() functionsdrivers/platform/x86/asus-wmi.c+7 -140 replies
7/9platform/x86: asus-wmi: ROG Ally increase wait time, allow MCU powersavedrivers/platform/x86/asus-wmi.c+2 -100 replies
8/9platform/x86: asus-wmi: Add support for MCU powersaveDocumentation/ABI/testing/sysfs-platform-asus-wmi drivers/platform/x86/asus-wmi.c+59 -00 replies
9/9platform/x86: asus-wmi: cleanup main struct to avoid some holesdrivers/platform/x86/asus-wmi.c+6 -110 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchIlpo Järvinen
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/9] asus-wmi: add new features, clean up, fixes

This patch series touches quite a few things along with adding support for some new features.

- Add support for mini-LED on 2024 ROG lpatops
- Add support for the gpu MUX WMI call on Vivobook laptops
- Add support for the POST boot sound on ROG laptops
- Add support for MCU power-save (ROG Ally only, saves more power on suspend)
- Store written values for ppt_* features
- Small formatting cleanup
- Small fixes to cleanup struct holes found with pahole

Obsoletes:
- https://lore.kernel.org/all/[email protected]/
- https://lore.kernel.org/all/[email protected]/
- https://lore.kernel.org/all/[email protected]/
- https://lore.kernel.org/all/[email protected]/
- https://lore.kernel.org/all/[email protected]/

Changelog:
- V1
- Mini-LED: use asus_wmi_get_devstate() and not asus_wmi_get_devstate_simple()
- Fix dates in Documentation/ABI/testing/sysfs-platform-asus-wmi
- Remove <name>_available bools and rely on devid for:
- gpu_mux
- mini_led
- kbd_rgb (TUF RGB LED)
- V2
- Fix formating on select if/else blocks shown by checkpatch.pl
- V3
- mini-led patch:
- Add error handling
- Add defines inplace of "magic" numbers
- Remove outdated comment
- Clarify existing comments
- post-sound patch:
- Add missing newline
- min-default-ppt patch
Use %u instead of %d in sysfs_emit()
- V4
- mini-led patch:
- Minor formatting cleanup

Luke D. Jones (9):
platform/x86: asus-wmi: add support for 2024 ROG Mini-LED platform/x86: asus-wmi: add support for Vivobook GPU MUX platform/x86: asus-wmi: add support variant of TUF RGB platform/x86: asus-wmi: support toggling POST sound platform/x86: asus-wmi: store a min default for ppt options platform/x86: asus-wmi: adjust formatting of ppt-<name>() functions platform/x86: asus-wmi: ROG Ally increase wait time, allow MCU
powersave
platform/x86: asus-wmi: Add support for MCU powersave platform/x86: asus-wmi: cleanup main struct to avoid some holes

 .../ABI/testing/sysfs-platform-asus-wmi       |  26 ++
 drivers/platform/x86/asus-wmi.c               | 409 ++++++++++++++----
 include/linux/platform_data/x86/asus-wmi.h    |   6 +
 3 files changed, 355 insertions(+), 86 deletions(-)
Signature · 1 line
2.44.0