Skip to content

git+curl 8.7.0 workaround

Jeff King git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2http: reset POSTFIELDSIZE when clearing curl handlehttp.c+1 -05 replies
2/2INSTALL: bump libcurl version to 7.21.3INSTALL+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] git+curl 8.7.0 workaround
Quoted 11 lines · Daniel Stenberg
Quoted 6 lines · Jeff King

I noticed some http-related failures in the test suite on my Debian unstable system, which recently got an upgraded curl package. It looks like it's related to cases where we use the remote-curl helper in "connect" mode (i.e., protocol v2) and the http buffer is small (requiring us to stream the data to curl). Besides just running t5551, an easy reproduction is:

This smells like a libcurl regression to me. I "imported" this into our issue tracker here: https://github.com/curl/curl/issues/13229

This was all resolved in that issue, but just to summarize for the list
here: it was a regression in curl and there's a fix already. Thanks Daniel for your (as usual) prompt digging into the problem (and likewise to Stefan for the actual fix).

Ultimately the issue will be fixed by moving to a different version of libcurl, but here's an easy workaround in the meantime, with a small doc cleanup I found along the way.

[1/2]: http: reset POSTFIELDSIZE when clearing curl handle [2/2]: INSTALL: bump libcurl version to 7.21.3

 INSTALL | 2 +-
 http.c  | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-Peff