Skip to content

xfs: sparse warning fixes

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5xfs: fix CIL sparse lock context warningsfs/xfs/xfs_log_cil.c fs/xfs/xfs_log_priv.h+3 -21 reply
2/5xfs: fix sparse warning in xfs_extent_busy_clearfs/xfs/xfs_extent_busy.c+23 -42 replies
3/5xfs: silence sparse warning when checking version numberfs/xfs/scrub/agheader.c+1 -22 replies
4/5xfs: remove unused is_rt_data_fork() functionfs/xfs/scrub/rmap_repair.c+0 -82 replies
5/5xfs: fix sparse warnings about unused interval tree functionsfs/xfs/scrub/bitmap.c+12 -102 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigDarrick J. Wong
1/5R-b
2/5R-b
3/5R-b R-b
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] xfs: sparse warning fixes

In chasing down a recent regression, I realised I wasn't running sparse regularly on my "fs/xfs-only" kernel builds, and so I missed a warning that would have prevented a bug from slipping through.

I've modified my build scripts to always run sparse when I do these delta builds as I develop code, and I found a few other warnings that needed to be addressed. No bugs were uncovered - they are simply modifications and/or annotations to the code to address the warnings and make them go away.

There remains a couple of sparse warnings in the transaction reservation calculations - sparse throws "too many tokens" warnings from the max(t4, max3(t1, t2, t3)) calculations. These are sparse code parser issues, not a code problem, so I have ignored them for now.