Skip to content

arm64: tlb: Fix TLBI RANGE operand

Gavin Shan linux-arm-kernel lkml 3 versions – Applied

Status from this message: Applied to arm64 (for-next/fixes), thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 16 repliesApplied
  2. v21 patch 4 repliesSuperseded
  3. v11 patch 4 repliesSuperseded

Changes in v3 from the cover letter

Improve __TLBI_RANGE_NUM() and its comments. Added patches to improve __TLBI_VADDR_RANGE() and __flush_tlb_range_nosync() (Marc)

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3arm64: tlb: Fix TLBI RANGE operandarch/arm64/include/asm/tlbflush.h+11 -95 replies
2/3arm64: tlb: Improve __TLBI_VADDR_RANGE()arch/arm64/include/asm/tlbflush.h+18 -113 replies
3/3arm64: tlb: Allow range operation for MAX_TLBI_RANGE_PAGESarch/arm64/include/asm/tlbflush.h+2 -25 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCatalin MarinasRyan RobertsAnshuman KhandualShaoqin Huang
SeriesR-b
1/3R-b R-b R-b
2/3R-b R-b R-b
3/3R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/3] arm64: tlb: Fix TLBI RANGE operand

A kernel crash on the destination VM after the live migration was reported by Yihuang Yu. The issue is only reproducible on NVidia's grace-hopper where TLBI RANGE feature is available. The kernel crash is caused by incomplete TLB flush and missed dirty page. For the root cause and analysis, please refer to PATCH[v3 1/3]'s commit log.

Thanks to Marc Zyngier who proposed all the code changes.

PATCH[1] fixes the kernel crash by extending __TLBI_RANGE_NUM() so that
the TLBI RANGE on the area with MAX_TLBI_RANGE_PAGES pages can be supported
PATCH[2] improves __TLBI_VADDR_RANGE() with masks and FIELD_PREP() PATCH[3] allows TLBI RANGE operation on the area with MAX_TLBI_RANGE_PAGES
pages in __flush_tlb_range_nosync()

v2: https://lists.infradead.org/pipermail/linux-arm-kernel/2024-April/917432.html
v1: https://lists.infradead.org/pipermail/linux-arm-kernel/2024-April/916972.html

Changelog
=========
v3:
Improve __TLBI_RANGE_NUM() and its comments. Added patches to improve __TLBI_VADDR_RANGE() and __flush_tlb_range_nosync() (Marc)
v2:
Improve __TLBI_RANGE_NUM() (Marc)

Gavin Shan (3):
arm64: tlb: Fix TLBI RANGE operand
arm64: tlb: Improve __TLBI_VADDR_RANGE()
arm64: tlb: Allow range operation for MAX_TLBI_RANGE_PAGES

 arch/arm64/include/asm/tlbflush.h | 53 ++++++++++++++++++-------------
 1 file changed, 31 insertions(+), 22 deletions(-)
Signature · 1 line
2.44.0