Skip to content

dev_printk: add dev_errp_probe() helper

Nuno Sa linux-iio lkml 3 versions – In review

Get series with b4
b4 am [email protected] change-id 20240404-dev-add_dev_errp_probe-69e7524c2803

Versions newest first

  1. v3 Latest4 patches 11 repliesIn review
  2. v24 patches 9 repliesSuperseded inferred link
  3. v14 patches 15 repliesSuperseded

Changes in v3 from the cover letter

* Patch 1:
- Removed parenthesis around macros;

* Patch 2:
- Removed local struct device *dev helper;
- Added missing \n to printk().

* Patch 4:
- Make sure to not double error code printing;
- Added missing new line.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4dev_printk: add new dev_err_probe() helpersinclude/linux/dev_printk.h+8 -04 replies
2/4iio: temperature: ltc2983: convert to dev_err_probe()drivers/iio/temperature/ltc2983.c+113 -1477 replies
3/4iio: backend: make use of dev_err_cast_probe()drivers/iio/industrialio-backend.c+3 -50 replies
4/4iio: common: scmi_iio: convert to dev_err_probe()drivers/iio/common/scmi_sensors/scmi_iio.c+19 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/4] dev_printk: add dev_errp_probe() helper

Main changes in v3 are Andy feedback on v2. Still note that I'm not adding a new variant for dev_err_* that takes an error pointer and return an int. I prefer to defer that if we really want such a variant. Anyways, here it goes v3 log:

v1:
* https://lore.kernel.org/all/[email protected]/

v2:
* https://lore.kernel.org/all/[email protected]/

v3:
* Patch 1:
- Removed parenthesis around macros;

* Patch 2:
- Removed local struct device *dev helper;
- Added missing \n to printk().

* Patch 4:
- Make sure to not double error code printing;
- Added missing new line.

---
Nuno Sa (4):
dev_printk: add new dev_err_probe() helpers
iio: temperature: ltc2983: convert to dev_err_probe()
iio: backend: make use of dev_err_cast_probe()
iio: common: scmi_iio: convert to dev_err_probe()

 drivers/iio/common/scmi_sensors/scmi_iio.c |  45 +++--
 drivers/iio/industrialio-backend.c         |   8 +-
 drivers/iio/temperature/ltc2983.c          | 260 +++++++++++++----------------
 include/linux/dev_printk.h                 |   8 +
 4 files changed, 143 insertions(+), 178 deletions(-)

---
base-commit: 234cb065ad82915ff8d06ce01e01c3e640b674d2
change-id: 20240404-dev-add_dev_errp_probe-69e7524c2803 --

Thanks!
- Nuno Sá