Skip to content

media: subdev: Improve stream enable/disable machinery

Tomi Valkeinen linux-media lkml 6 versions – In review

Get series with b4
b4 am [email protected] change-id 20240404-enable-streams-impro-db8bcd898471

Versions newest first

  1. v6 Latest11 patches 3 repliesIn review
  2. v510 patches 11 repliesSuperseded
  3. v410 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v39 patches24 repliesSuperseded
v29 patches9 repliesSuperseded
v14 patches11 repliesSuperseded

Changes in v6 from the cover letter

- v4l2_subdev_enable_streams() and v4l2_subdev_disable_streams()
accidentally returned -EINVAL when a stream was already
enabled/disabled. Change it back to -EALREADY.
- Add TODO note about privacy leds to "media: subdev: Support
single-stream case in v4l2_subdev_enable/disable_streams()"
- New commit "media: subdev: Improve s_stream documentation"
- Link to v5: https://lore.kernel.org/r/[email protected]

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11media: subdev: Add privacy led helpersdrivers/media/v4l2-core/v4l2-subdev.c+21 -90 replies
2/11media: subdev: Use v4l2_subdev_has_op() in v4l2_subdev_enable/disable_streams()drivers/media/v4l2-core/v4l2-subdev.c+2 -20 replies
3/11media: subdev: Add checks for subdev featuresdrivers/media/v4l2-core/v4l2-subdev.c+27 -00 replies
4/11media: subdev: Fix use of sd->enabled_streams in call_s_stream()drivers/media/v4l2-core/v4l2-subdev.c include/media/v4l2-subdev.h+5 -60 replies
5/11media: subdev: Improve v4l2_subdev_enable/disable_streams_fallbackdrivers/media/v4l2-core/v4l2-subdev.c include/media/v4l2-subdev.h+44 -330 replies
6/11media: subdev: Add v4l2_subdev_is_streaming()drivers/media/v4l2-core/v4l2-subdev.c include/media/v4l2-subdev.h+38 -00 replies
7/11media: subdev: Support privacy led in v4l2_subdev_enable/disable_streams()drivers/media/v4l2-core/v4l2-subdev.c+9 -00 replies
8/11media: subdev: Refactor v4l2_subdev_enable/disable_streams()drivers/media/v4l2-core/v4l2-subdev.c+60 -490 replies
9/11media: subdev: Support single-stream case in v4l2_subdev_enable/disable_streams()drivers/media/v4l2-core/v4l2-subdev.c+86 -1080 replies
10/11media: subdev: Support non-routing subdevs in v4l2_subdev_s_stream_helper()drivers/media/v4l2-core/v4l2-subdev.c+16 -70 replies
11/11media: subdev: Improve s_stream documentationinclude/media/v4l2-subdev.h+9 -03 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchUmang JainLaurent Pinchart
1/11R-b T-b R-b
2/11R-b T-b R-b
3/11R-b T-b R-b
4/11R-b T-b R-b
5/11T-b R-b
6/11R-b T-b R-b
7/11R-b T-b R-b
8/11T-b R-b
9/11T-b R-b
10/11T-b R-b
11/11R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/11] media: subdev: Improve stream enable/disable machinery

This series works on the .s_stream, .enable_streams, .disable_streams related code. The main feature introduced here, in the last two patchs, is adding support for .enable/disable_streams() for subdevs that do not implement full streams support.

Additionally we add support for the privacy led when v4l2_subdev_enable/disable_streams() is used.

I have tested this on RPi5.

Tomi

---
Changes in v6:
- v4l2_subdev_enable_streams() and v4l2_subdev_disable_streams()
accidentally returned -EINVAL when a stream was already
enabled/disabled. Change it back to -EALREADY.
- Add TODO note about privacy leds to "media: subdev: Support
single-stream case in v4l2_subdev_enable/disable_streams()"
- New commit "media: subdev: Improve s_stream documentation"
- Link to v5: https://lore.kernel.org/r/[email protected]

Changes in v5:
- Fix issues with non-routing case:
- Always set 'found_streams' variable instead of leaving it
uninitialized in "Support single-stream case in v4l2_subdev_enable/disable_streams()"
- Fix the "implicit" stream from bit 1 to bit 0 in "Support
non-routing subdevs in v4l2_subdev_s_stream_helper()"
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Added Rb tags
- Rename 'streaming_enabled' to 's_stream_enabled'
- Cosmetic changes (comments / patch descs)
- Added new patch "media: subdev: Support non-routing subdevs in v4l2_subdev_s_stream_helper()".
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Rebased on top of "[PATCH v2 1/1] media: v4l: Don't turn on privacy LED if streamon fails"
- Drop extra "!!" in "media: subdev: Fix use of sd->enabled_streams in call_s_stream()"
- Enable privacy LED after a succesfull stream enable in "media: subdev: Support privacy led in v4l2_subdev_enable/disable_streams()"
- Init 'cfg' variable when declaring in "media: subdev: Refactor v4l2_subdev_enable/disable_streams()"
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- New patches for privacy led
- Use v4l2_subdev_has_op()
- Use BITS_PER_BYTE instead of 8
- Fix 80+ line issues
- Fix typos
- Check for pad < 64 also in the non-routing .enable/disable_streams code path
- Dropped "media: subdev: Support enable/disable_streams for non-streams
subdevs", which is implemented in a different way in new patches in this series
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Tomi Valkeinen (11):
media: subdev: Add privacy led helpers
media: subdev: Use v4l2_subdev_has_op() in v4l2_subdev_enable/disable_streams()
media: subdev: Add checks for subdev features
media: subdev: Fix use of sd->enabled_streams in call_s_stream()
media: subdev: Improve v4l2_subdev_enable/disable_streams_fallback
media: subdev: Add v4l2_subdev_is_streaming()
media: subdev: Support privacy led in v4l2_subdev_enable/disable_streams()
media: subdev: Refactor v4l2_subdev_enable/disable_streams()
media: subdev: Support single-stream case in v4l2_subdev_enable/disable_streams()
media: subdev: Support non-routing subdevs in v4l2_subdev_s_stream_helper()
media: subdev: Improve s_stream documentation

 drivers/media/v4l2-core/v4l2-subdev.c | 385 ++++++++++++++++++++--------------
 include/media/v4l2-subdev.h           |  34 ++-
 2 files changed, 261 insertions(+), 158 deletions(-)

---
base-commit: e42a204f0519a2540f1507ac2798be2aeaa76bee
change-id: 20240404-enable-streams-impro-db8bcd898471

Best regards,

Signature · 1 line
Tomi Valkeinen <[email protected]>