Skip to content

s390: PG_arch_1+folio cleanups for uv+hugetlb

David Hildenbrand kvm linux-s390 lkml 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 2 repliesApplied
  2. v210 patches 13 repliesSuperseded
  3. v15 patches 15 repliesSuperseded

Changes in v3 from the cover letter

* "s390/uv: split large folios in gmap_make_secure()" -> Spelling fix
* "s390/hugetlb: convert PG_arch_1 code to work on folio->flags" -> Extended patch description

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/10s390/uv: don't call folio_wait_writeback() without a folio referencearch/s390/kernel/uv.c+8 -00 replies
2/10s390/uv: gmap_make_secure() cleanups for further changesarch/s390/kernel/uv.c+40 -260 replies
3/10s390/uv: split large folios in gmap_make_secure()arch/s390/kernel/uv.c+25 -60 replies
4/10s390/uv: convert PG_arch_1 users to only work on small foliosarch/s390/include/asm/page.h arch/s390/kernel/uv.c+27 -160 replies
5/10s390/uv: update PG_arch_1 commentarch/s390/kernel/uv.c+4 -50 replies
6/10s390/uv: make uv_convert_from_secure() a static functionarch/s390/include/asm/uv.h arch/s390/kernel/uv.c+1 -70 replies
7/10s390/uv: convert uv_destroy_owned_page() to uv_destroy_(folio|pte)()arch/s390/include/asm/pgtable.h arch/s390/include/asm/uv.h arch/s390/kernel/uv.c +1 more+30 -120 replies
8/10s390/uv: convert uv_convert_owned_from_secure() to uv_convert_from_secure_(folio|pte)()arch/s390/include/asm/pgtable.h arch/s390/include/asm/uv.h arch/s390/kernel/uv.c+18 -100 replies
9/10s390/uv: implement HAVE_ARCH_MAKE_FOLIO_ACCESSIBLEarch/s390/include/asm/page.h arch/s390/kernel/uv.c arch/s390/mm/fault.c+22 -130 replies
10/10s390/hugetlb: convert PG_arch_1 code to work on folio->flagsarch/s390/mm/gmap.c arch/s390/mm/hugetlbpage.c+6 -60 replies

Reviews trailers per patch

9 of 10 patches have a Reviewed-by or Acked-by.

PatchClaudio Imbrenda
1/10R-b
2/10R-b
3/10
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/10] s390: PG_arch_1+folio cleanups for uv+hugetlb

Rebased on 390x/features. Cleanups around PG_arch_1 and folio handling in UV and hugetlb code.

One "easy" fix upfront. Another issue I spotted is documented in [1].

Once this hits upstream, we can remove HAVE_ARCH_MAKE_PAGE_ACCESSIBLE from core-mm and s390x, so only the folio variant will remain.

Compile tested, but not runtime tested with UV, I'll appreciate some testing help from people with UV access and experience.

[1] https://lkml.kernel.org/r/[email protected]

v2 -> v3:
* "s390/uv: split large folios in gmap_make_secure()" -> Spelling fix
* "s390/hugetlb: convert PG_arch_1 code to work on folio->flags" -> Extended patch description

v1 -> v2:
* Rebased on s390x/features:
* "s390/hugetlb: convert PG_arch_1 code to work on folio->flags" -> pmd_folio() not available on s390x/features
* "s390/uv: don't call folio_wait_writeback() without a folio reference" -> Willy's folio conversion is in s390x/features
* "s390/uv: convert PG_arch_1 users to only work on small folios" -> Add comments
* Rearrange code and handle split_folio() return values properly. New patches to handle splitting:
-> "s390/uv: gmap_make_secure() cleanups for further changes" -> "s390/uv: split large folios in gmap_make_secure()"
* Added more cleanups:
-> "s390/uv: make uv_convert_from_secure() a static function" -> "s390/uv: convert uv_destroy_owned_page() to uv_destroy_(folio|pte)()" -> "s390/uv: convert uv_convert_owned_from_secure() to

     uv_convert_from_secure_(folio|pte)()"

-> "s390/mm: implement HAVE_ARCH_MAKE_FOLIO_ACCESSIBLE"

Cc Heiko Carstens <[email protected]>
Cc Vasily Gorbik <[email protected]>
Cc Alexander Gordeev <[email protected]>
Cc Christian Borntraeger <[email protected]>
Cc Sven Schnelle <[email protected]>
Cc Janosch Frank <[email protected]>
Cc Claudio Imbrenda <[email protected]>
Cc Gerald Schaefer <[email protected]>
Cc Matthew Wilcox (Oracle) <[email protected]>
Cc Thomas Huth <[email protected]>

David Hildenbrand (10):
s390/uv: don't call folio_wait_writeback() without a folio reference s390/uv: gmap_make_secure() cleanups for further changes s390/uv: split large folios in gmap_make_secure() s390/uv: convert PG_arch_1 users to only work on small folios s390/uv: update PG_arch_1 comment
s390/uv: make uv_convert_from_secure() a static function s390/uv: convert uv_destroy_owned_page() to uv_destroy_(folio|pte)() s390/uv: convert uv_convert_owned_from_secure() to
uv_convert_from_secure_(folio|pte)()
s390/uv: implement HAVE_ARCH_MAKE_FOLIO_ACCESSIBLE s390/hugetlb: convert PG_arch_1 code to work on folio->flags

 arch/s390/include/asm/page.h    |   5 +
 arch/s390/include/asm/pgtable.h |   8 +-
 arch/s390/include/asm/uv.h      |  12 +-
 arch/s390/kernel/uv.c           | 207 +++++++++++++++++++++-----------
 arch/s390/mm/fault.c            |  14 ++-
 arch/s390/mm/gmap.c             |  10 +-
 arch/s390/mm/hugetlbpage.c      |   8 +-
 7 files changed, 172 insertions(+), 92 deletions(-)
Signature · 1 line
2.45.0