Skip to content

perf annotate: More memory footprint reduction

Namhyung Kim linux-perf-users lkml 1 version Applied

Status from this message: Thanks, applied to perf-tools-next,

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/9perf annotate: Fix annotation_calc_lines()tools/perf/util/annotate.c+6 -40 replies
2/9perf annotate: Staticize some local functionstools/perf/util/annotate.c tools/perf/util/annotate.h+5 -60 replies
3/9perf annotate: Introduce annotated_source__get_line()tools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+25 -60 replies
4/9perf annotate: Check annotation lines more efficientlytools/perf/util/annotate.c+35 -210 replies
5/9perf annotate: Get rid of offsets arraytools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+7 -290 replies
6/9perf annotate: Move widths struct to annotated_sourcetools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+35 -320 replies
7/9perf annotate: Move max_jump_sources struct to annotated_sourcetools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+7 -50 replies
8/9perf annotate: Move nr_events struct to annotated_sourcetools/perf/util/annotate.c tools/perf/util/annotate.h+6 -50 replies
9/9perf annotate: Move start field struct to annotated_sourcetools/perf/util/annotate.c tools/perf/util/annotate.h+6 -61 reply

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by.

PatchIan Rogers
SeriesT-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 0/9] perf annotate: More memory footprint reduction

Hello,

This work is continuation of the previous work to reduce the memory usage in symbol and annotation structures. Basically I moved some fields in the annotation which consume spaces in the struct symbol which is allocated regardless if the symbol has a sample or not when annotation is enabled.

With this change applied, the struct annotation only has two members - annotated_source and annotated_branch. The next step would be to remove the struct annotation and to have a hash table from symbol to each annotated struct directly.

No function changes intended.

The code is available at perf/annotate-diet-v3 branch in

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (9):
perf annotate: Fix annotation_calc_lines()
perf annotate: Staticize some local functions
perf annotate: Introduce annotated_source__get_line() perf annotate: Check annotation lines more efficiently perf annotate: Get rid of offsets array
perf annotate: Move widths struct to annotated_source perf annotate: Move max_jump_sources struct to annotated_source perf annotate: Move nr_events struct to annotated_source perf annotate: Move start field struct to annotated_source

 tools/perf/ui/browsers/annotate.c |  15 ++-
 tools/perf/util/annotate.c        | 174 +++++++++++++++++-------------
 tools/perf/util/annotate.h        |  39 +++----
 3 files changed, 123 insertions(+), 105 deletions(-)

base-commit: b6347cb5e04e9c1d17342ab46e2ace2d448de727

Signature · 1 line
2.44.0.478.gd926399ef9-goog