perf annotate: More memory footprint reduction
Status from this message: Thanks, applied to perf-tools-next,
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | perf annotate: Fix annotation_calc_lines()tools/ | +6 | 0 replies | |
| 2/9 | perf annotate: Staticize some local functionstools/ tools/ | +5 | 0 replies | |
| 3/9 | perf annotate: Introduce annotated_source__get_line()tools/ tools/ tools/ | +25 | 0 replies | |
| 4/9 | perf annotate: Check annotation lines more efficientlytools/ | +35 | 0 replies | |
| 5/9 | perf annotate: Get rid of offsets arraytools/ tools/ tools/ | +7 | 0 replies | |
| 6/9 | perf annotate: Move widths struct to annotated_sourcetools/ tools/ tools/ | +35 | 0 replies | |
| 7/9 | perf annotate: Move max_jump_sources struct to annotated_sourcetools/ tools/ tools/ | +7 | 0 replies | |
| 8/9 | perf annotate: Move nr_events struct to annotated_sourcetools/ tools/ | +6 | 0 replies | |
| 9/9 | perf annotate: Move start field struct to annotated_sourcetools/ tools/ | +6 | 1 reply |
Reviews trailers per patch
None of the 9 patches has a Reviewed-by or Acked-by.
| Patch | Ian Rogers |
|---|---|
| Series | T-b |
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHSET 0/9] perf annotate: More memory footprint reduction
Hello,
This work is continuation of the previous work to reduce the memory usage in symbol and annotation structures. Basically I moved some fields in the annotation which consume spaces in the struct symbol which is allocated regardless if the symbol has a sample or not when annotation is enabled.
With this change applied, the struct annotation only has two members - annotated_source and annotated_branch. The next step would be to remove the struct annotation and to have a hash table from symbol to each annotated struct directly.
No function changes intended.
The code is available at perf/annotate-diet-v3 branch in
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Thanks,
Namhyung
Namhyung Kim (9):
perf annotate: Fix annotation_calc_lines()
perf annotate: Staticize some local functions
perf annotate: Introduce annotated_source__get_line() perf annotate: Check annotation lines more efficiently perf annotate: Get rid of offsets array
perf annotate: Move widths struct to annotated_source perf annotate: Move max_jump_sources struct to annotated_source perf annotate: Move nr_events struct to annotated_source perf annotate: Move start field struct to annotated_source
tools/perf/ui/browsers/annotate.c | 15 ++- tools/perf/util/annotate.c | 174 +++++++++++++++++------------- tools/perf/util/annotate.h | 39 +++---- 3 files changed, 123 insertions(+), 105 deletions(-)
base-commit: b6347cb5e04e9c1d17342ab46e2ace2d448de727
Signature · 1 line
2.44.0.478.gd926399ef9-goog