Skip to content

ASoC: Intel: avs: Fixes and cleanups for 6.10

Cezary Rojewski alsa-devel linux-sound oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13ASoC: Intel: avs: Restore stream decoupling on preparesound/soc/intel/avs/pcm.c+4 -00 replies
2/13ASoC: Intel: avs: Fix debug-slot offset calculationsound/soc/intel/avs/icl.c+2 -30 replies
3/13ASoC: Intel: avs: Silence false-positive memcpy() warningssound/soc/intel/avs/messages.h sound/soc/intel/avs/path.c+3 -30 replies
4/13ASoC: Intel: avs: Fix config_length for config-less copierssound/soc/intel/avs/path.c+3 -50 replies
5/13ASoC: Intel: avs: Fix ASRC module initializationsound/soc/intel/avs/path.c+1 -00 replies
6/13ASoC: Intel: avs: Replace risky functions with safer variantssound/soc/intel/avs/loader.c sound/soc/intel/avs/pcm.c+3 -30 replies
7/13ASoC: Intel: avs: Fix potential integer overflowsound/soc/intel/avs/cldma.c+1 -10 replies
8/13ASoC: Intel: avs: Test result of avs_get_module_entry()sound/soc/intel/avs/probes.c+9 -50 replies
9/13ASoC: Intel: avs: Remove dead codesound/soc/intel/avs/path.c+0 -20 replies
10/13ASoC: Intel: avs: Wake from D0ix when starting streamingsound/soc/intel/avs/icl.c+4 -00 replies
11/13ASoC: Intel: avs: Init debugfs before booting firmwaresound/soc/intel/avs/core.c+2 -20 replies
12/13ASoC: Intel: avs: Add assert_static to guarantee ABI sizessound/soc/intel/avs/avs.h sound/soc/intel/avs/icl.c sound/soc/intel/avs/loader.c +1 more+49 -00 replies
13/13ASoC: Intel: avs: Rule invalid buffer and period sizes outsound/soc/intel/avs/pcm.c+28 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] ASoC: Intel: avs: Fixes and cleanups for 6.10

Set of changes targeting the avs-driver only. No new features, patchset either fixes or fortifies existing code.

Patchset starts off with a fix for debugbility on ICL+ platforms which I have forgotten to fixup when providing support for these initially. The next two address copier module initialization, most importantly, silence the gcc 'field-spanning write' false-positive.

The following four:
6/13 ASoC: Intel: avs: Replace risky functions with safer variants 7/13 ASoC: Intel: avs: Fix potential integer overflow 8/13 ASoC: Intel: avs: Test result of avs_get_module_entry() 9/13 ASoC: Intel: avs: Remove dead code

address problems found out by Coverity static analysis tool.

The last two worth mentioning are: recommendation from the firmware team to wake subsystem from D0ix when starting any pipeline -and- shielding against invalid period/buffer sizes. Audio format shall be taken into consideration when calculating either of these.

Amadeusz Sławiński (2):
ASoC: Intel: avs: Restore stream decoupling on prepare
ASoC: Intel: avs: Add assert_static to guarantee ABI sizes

Cezary Rojewski (11):
ASoC: Intel: avs: Fix debug-slot offset calculation
ASoC: Intel: avs: Silence false-positive memcpy() warnings
ASoC: Intel: avs: Fix config_length for config-less copiers
ASoC: Intel: avs: Fix ASRC module initialization
ASoC: Intel: avs: Replace risky functions with safer variants
ASoC: Intel: avs: Fix potential integer overflow
ASoC: Intel: avs: Test result of avs_get_module_entry()
ASoC: Intel: avs: Remove dead code
ASoC: Intel: avs: Wake from D0ix when starting streaming
ASoC: Intel: avs: Init debugfs before booting firmware
ASoC: Intel: avs: Rule invalid buffer and period sizes out

 sound/soc/intel/avs/avs.h      |  1 +
 sound/soc/intel/avs/cldma.c    |  2 +-
 sound/soc/intel/avs/core.c     |  4 +--
 sound/soc/intel/avs/icl.c      | 12 ++++++---
 sound/soc/intel/avs/loader.c   |  6 +++--
 sound/soc/intel/avs/messages.h | 47 ++++++++++++++++++++++++++++++++--
 sound/soc/intel/avs/path.c     | 13 ++++------
 sound/soc/intel/avs/pcm.c      | 34 +++++++++++++++++++++++-
 sound/soc/intel/avs/probes.c   | 14 ++++++----
 9 files changed, 109 insertions(+), 24 deletions(-)
Signature · 1 line
2.25.1