Skip to content

Panel Replay fixes and clean ups

Jouni Högander intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/i915/psr: Add some documentation of variables used in psr codedrivers/gpu/drm/i915/display/intel_psr.c+16 -00 replies
2/8drm/i915/psr: Set intel_crtc_state->has_psr on panel replay as welldrivers/gpu/drm/i915/display/intel_psr.c+6 -50 replies
3/8drm/i915/psr: Intel_psr_pause/resume needs to support panel replaydrivers/gpu/drm/i915/display/intel_psr.c+2 -20 replies
4/8drm/i915/psr: Do not update phy power state in case of non-eDP panel replaydrivers/gpu/drm/i915/display/intel_psr.c+8 -40 replies
5/8drm/i915/psr: Check possible errors for panel replay as welldrivers/gpu/drm/i915/display/intel_psr.c+16 -50 replies
6/8drm/i915/psr: Do not write registers/bits not applicable for panel replaydrivers/gpu/drm/i915/display/intel_psr.c+45 -250 replies
7/8drm/i915/psr: Unify panel replay enable/disable sinkdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_psr.c drivers/gpu/drm/i915/display/intel_psr.h+50 -230 replies
8/8drm/i915/psr: Panel replay has to be enabled before link trainingdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_psr.c +1 more+23 -30 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchAnimesh Manna
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] Panel Replay fixes and clean ups

This patch set is a subset of Panel Replay selective update support set:

https://patchwork.freedesktop.org/series/128193/

It contains fixes and clean ups to current Panel Replay implementation:

Several needed functions are not executed for panel replay Ensure link training follows enabling panel replay on sink side Do not update phy power state for panel replay.
Do not apply workarounds not applicable for panel replay Do not write registers/bits not applicable for panel replay Unify panel replay enable/disable sink
Document boolean variables used by PSR code

All patches are reviewed. Sending now as a standalone set for CI results before merging.

Jouni Högander (8):
drm/i915/psr: Add some documentation of variables used in psr code drm/i915/psr: Set intel_crtc_state->has_psr on panel replay as well drm/i915/psr: Intel_psr_pause/resume needs to support panel replay drm/i915/psr: Do not update phy power state in case of non-eDP panel
replay
drm/i915/psr: Check possible errors for panel replay as well drm/i915/psr: Do not write registers/bits not applicable for panel
replay
drm/i915/psr: Unify panel replay enable/disable sink drm/i915/psr: Panel replay has to be enabled before link training

 drivers/gpu/drm/i915/display/intel_ddi.c     |  11 +-
 drivers/gpu/drm/i915/display/intel_display.c |  12 ++
 drivers/gpu/drm/i915/display/intel_dp.c      |   8 +
 drivers/gpu/drm/i915/display/intel_psr.c     | 197 +++++++++++++------
 drivers/gpu/drm/i915/display/intel_psr.h     |   5 +
 5 files changed, 166 insertions(+), 67 deletions(-)
Signature · 1 line
2.34.1