Skip to content

hw/net/lan9118: Fix overflow in TX FIFO

Philippe Mathieu-Daudé qemu-arm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 10 repliesIn review
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Renamed definition as MIL_TXFIFO_SIZE
- Addressed Peter review comments in patches 1 & 2 (add comment, return TXE INT)
- Trivial patches while digesting Peter's analysis [*]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11hw/net/lan9118: Replace magic '2048' value by MIL_TXFIFO_SIZE definitionhw/net/lan9118.c+9 -31 reply
2/11hw/net/lan9118: Fix overflow in MIL TX FIFOhw/net/lan9118.c+15 -11 reply
3/11hw/net/lan9118: Remove duplicated assignmenthw/net/lan9118.c+0 -11 reply
4/11hw/net/lan9118: Replace magic '5' value by TX_FIF_SZ_RESET definitionhw/net/lan9118.c+3 -11 reply
5/11hw/net/lan9118: Add definitions for FIFO allocated sizeshw/net/lan9118.c+11 -01 reply
6/11hw/net/lan9118: Use TX_DATA_FIFO_BYTES definitionhw/net/lan9118.c+1 -10 replies
7/11hw/net/lan9118: Rename tx_fifo_size -> tx_fifo_byteshw/net/lan9118.c+5 -51 reply
8/11hw/net/lan9118: Use RX_STATUS_FIFO_BYTES definitionhw/net/lan9118.c+5 -41 reply
9/11hw/net/lan9118: Rename rx_status_fifo_size -> rx_status_fifo_wordcounthw/net/lan9118.c+8 -81 reply
10/11hw/net/lan9118: Use RX_DATA_FIFO_BYTES definitionhw/net/lan9118.c+5 -31 reply
11/11hw/net/lan9118: Rename rx_fifo_size -> rx_fifo_wordcounthw/net/lan9118.c+11 -100 replies

Reviews trailers per patch

4 of 11 patches have a Reviewed-by or Acked-by.

PatchPeter Maydell
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH-for-9.0 v2 00/11] hw/net/lan9118: Fix overflow in TX FIFO

Fix for https://gitlab.com/qemu-project/qemu/-/issues/2267

Since v1:
- Renamed definition as MIL_TXFIFO_SIZE
- Addressed Peter review comments in patches 1 & 2 (add comment, return TXE INT)
- Trivial patches while digesting Peter's analysis [*]

More work expected during 9.1.

[*] https://lore.kernel.org/qemu-devel/CAFEAcA8vvURMn2FaDP9tXtP5eCMs6-XFOCR9ypo=WBH+6g5prw@mail.gmail.com/

Philippe Mathieu-Daudé (11):
hw/net/lan9118: Replace magic '2048' value by MIL_TXFIFO_SIZE
definition
hw/net/lan9118: Fix overflow in MIL TX FIFO hw/net/lan9118: Remove duplicated assignment hw/net/lan9118: Replace magic '5' value by TX_FIF_SZ_RESET definition hw/net/lan9118: Add definitions for FIFO allocated sizes hw/net/lan9118: Use TX_DATA_FIFO_BYTES definition hw/net/lan9118: Rename tx_fifo_size -> tx_fifo_bytes hw/net/lan9118: Use RX_STATUS_FIFO_BYTES definition hw/net/lan9118: Rename rx_status_fifo_size -> rx_status_fifo_wordcount hw/net/lan9118: Use RX_DATA_FIFO_BYTES definition hw/net/lan9118: Rename rx_fifo_size -> rx_fifo_wordcount

 hw/net/lan9118.c | 104 +++++++++++++++++++++++++++++++----------------
 1 file changed, 70 insertions(+), 34 deletions(-)
Signature · 1 line
2.41.0