hw/net/lan9118: Fix overflow in TX FIFO
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest11 patches 10 repliesIn review
- v12 patches 3 repliesSuperseded
Changes in v2 from the cover letter
- Renamed definition as MIL_TXFIFO_SIZE
- Addressed Peter review comments in patches 1 & 2 (add comment, return TXE INT)
- Trivial patches while digesting Peter's analysis [*]
Patches in v2 No applies recorded yet
Reviews trailers per patch
4 of 11 patches have a Reviewed-by or Acked-by.
| Patch | Peter Maydell |
|---|---|
| 1/11 | R-b |
| 2/11 | R-b |
| 3/11 | R-b |
| 4/11 | R-b |
| 5/11 | |
| 6/11 | |
| 7/11 | |
| 8/11 | |
| 9/11 | |
| 10/11 | |
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH-for-9.0 v2 00/11] hw/net/lan9118: Fix overflow in TX FIFO
Fix for https://gitlab.com/qemu-project/qemu/-/issues/2267
Since v1:
- Renamed definition as MIL_TXFIFO_SIZE
- Addressed Peter review comments in patches 1 & 2 (add comment, return TXE INT)
- Trivial patches while digesting Peter's analysis [*]
More work expected during 9.1.
Philippe Mathieu-Daudé (11):
hw/net/lan9118: Replace magic '2048' value by MIL_TXFIFO_SIZE
definition
hw/net/lan9118: Fix overflow in MIL TX FIFO hw/net/lan9118: Remove duplicated assignment hw/net/lan9118: Replace magic '5' value by TX_FIF_SZ_RESET definition hw/net/lan9118: Add definitions for FIFO allocated sizes hw/net/lan9118: Use TX_DATA_FIFO_BYTES definition hw/net/lan9118: Rename tx_fifo_size -> tx_fifo_bytes hw/net/lan9118: Use RX_STATUS_FIFO_BYTES definition hw/net/lan9118: Rename rx_status_fifo_size -> rx_status_fifo_wordcount hw/net/lan9118: Use RX_DATA_FIFO_BYTES definition hw/net/lan9118: Rename rx_fifo_size -> rx_fifo_wordcount
hw/net/lan9118.c | 104 +++++++++++++++++++++++++++++++---------------- 1 file changed, 70 insertions(+), 34 deletions(-)
Signature · 1 line
2.41.0