Skip to content

flower: validate control flags

Asbjørn Sloth Tønnesen lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesApplied 4/4
  2. v24 patches 3 repliesSuperseded
  3. v16 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- Added Reviewed-by from Louis Peens (first two patches)
- Properly fixed kernel-doc format

Patches in v3 All 4 applied

#Subject and filesSizeRepliesApplied
1/4flow_offload: add control flag checking helpersinclude/net/flow_offload.h+55 -00 repliesApplied
2/4nfp: flower: fix check for unsupported control flagsdrivers/net/ethernet/netronome/nfp/flower/offload.c+3 -30 repliesApplied
3/4net: prestera: flower: validate control flagsdrivers/net/ethernet/marvell/prestera/prestera_flower.c+4 -00 repliesApplied
4/4net: dsa: microchip: ksz9477: flower: validate control flagsdrivers/net/dsa/microchip/ksz9477_tc_flower.c+3 -00 repliesApplied

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchLouis Peens
1/4R-b
2/4R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/4] flower: validate control flags

I have reviewed the flower control flags code. In all, but one (sfc), the flags field wasn't checked properly for unsupported flags.

In this series I have only included a single example user for each helper function. Once the helpers are in, I will submit patches for all other drivers implementing flower.

After which there will be:
- 6 drivers using flow_rule_is_supp_control_flags()
- 8 drivers using flow_rule_has_control_flags()
- 11 drivers using flow_rule_match_has_control_flags()

---
Changelog:

v3:
- Added Reviewed-by from Louis Peens (first two patches)
- Properly fixed kernel-doc format

v2: https://lore.kernel.org/netdev/[email protected]/
- Squashed the 3 helper functions to one commmit (requested by Baowen Zheng)
- Renamed helper functions to avoid double negatives (suggested by Louis Peens)
- Reverse booleans in some functions and callsites to align with new names
- Fix autodoc format

v1: https://lore.kernel.org/netdev/[email protected]/

Asbjørn Sloth Tønnesen (4):
flow_offload: add control flag checking helpers
nfp: flower: fix check for unsupported control flags
net: prestera: flower: validate control flags
net: dsa: microchip: ksz9477: flower: validate control flags

 drivers/net/dsa/microchip/ksz9477_tc_flower.c |  3 +
 .../marvell/prestera/prestera_flower.c        |  4 ++
 .../ethernet/netronome/nfp/flower/offload.c   |  6 +-
 include/net/flow_offload.h                    | 55 +++++++++++++++++++
 4 files changed, 65 insertions(+), 3 deletions(-)
Signature · 1 line
2.43.0