Skip to content

gpiolib: Fix gpio_lookup_flags mess and add Return sections

Andy Shevchenko brcm80211 linux-acpi linux-gpio linux-wireless lkml llvm oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 20 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2gpiolib: Fix a mess with the GPIO_* flagsdrivers/gpio/gpiolib-of.c drivers/gpio/gpiolib.c drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c +2 more+12 -2615 replies
2/2gpiolib: Update the kernel documentation - add Return sectionsdrivers/gpio/gpiolib-acpi.c drivers/gpio/gpiolib-cdev.c drivers/gpio/gpiolib-devres.c +5 more+233 -595 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchRandy Dunlap
1/2
2/2R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] gpiolib: Fix gpio_lookup_flags mess and add Return sections

While reviewing another patch I have realised that enum gpio_lookup_flags messes up with GPIO_* flags definitions. Hence the first patch fix. Second one is an updated version of adding Return sections to the kernel-doc.

The series is made in assumption that the patches will land in this order, but if applied separately, e.g., one to for-current and one to for-next branches, no conflicts should appear.

In v2:
- new patch 1
- replaces error-code by errno (Randy)
- added tags to patch 2 (Randy)

Andy Shevchenko (2):
gpiolib: Fix a mess with the GPIO_* flags
gpiolib: Update the kernel documentation - add Return sections

 drivers/gpio/gpiolib-acpi.c                   |  22 ++-
 drivers/gpio/gpiolib-cdev.c                   |   8 +-
 drivers/gpio/gpiolib-devres.c                 |  44 ++++-
 drivers/gpio/gpiolib-legacy.c                 |   3 +
 drivers/gpio/gpiolib-of.c                     |  53 ++++--
 drivers/gpio/gpiolib-swnode.c                 |   4 +-
 drivers/gpio/gpiolib-sysfs.c                  |   6 +-
 drivers/gpio/gpiolib.c                        | 165 ++++++++++++++----
 .../broadcom/brcm80211/brcmsmac/led.c         |   2 +-
 include/linux/gpio/driver.h                   |   3 +-
 include/linux/gpio/machine.h                  |  20 +--
 11 files changed, 245 insertions(+), 85 deletions(-)
Signature · 1 line
2.43.0.rc1.1.gbec44491f096