Skip to content

perf test: "object code reading" test fixes

James Clark linux-perf-users lkml 2 versions – Applied

Status from this message: Thanks, applied to perf-tools-next,

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesApplied
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* Put data symbol test fix first so that bisecting still works on N1
* Instead of skipping "test data symbol" on N1, add some noise into the loop.
* Add a commit to replace the only usage of lscpu in the tests with uname

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4perf tests: Make "test data symbol" more robust on Neoverse N1tools/perf/tests/workloads/datasym.c+16 -00 replies
2/4perf tests: Apply attributes to all events in object code reading testtools/perf/tests/code-reading.c+5 -50 replies
3/4perf map: Remove kernel map before updating start and end addressestools/perf/util/machine.c+1 -10 replies
4/4perf tests: Remove dependency on lscputools/perf/tests/shell/test_arm_callgraph_fp.sh+3 -10 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIan RogersNamhyung Kim
SeriesR-b A-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] perf test: "object code reading" test fixes

A few fixes around the object code reading test. The first patch appears to be unrelated, but in this case the data symbol test is broken on Arm N1 by the second commit.

Changes since V1:
* Put data symbol test fix first so that bisecting still works on N1
* Instead of skipping "test data symbol" on N1, add some noise into the loop.
* Add a commit to replace the only usage of lscpu in the tests with uname

James Clark (4):
perf tests: Make "test data symbol" more robust on Neoverse N1 perf tests: Apply attributes to all events in object code reading test perf map: Remove kernel map before updating start and end addresses perf tests: Remove dependency on lscpu

 tools/perf/tests/code-reading.c                 | 10 +++++-----
 tools/perf/tests/shell/test_arm_callgraph_fp.sh |  4 +++-
 tools/perf/tests/workloads/datasym.c            | 16 ++++++++++++++++
 tools/perf/util/machine.c                       |  2 +-
 4 files changed, 25 insertions(+), 7 deletions(-)
Signature · 1 line
2.34.1