Skip to content

gpio-tools: allow specifying longer time periods

Bartosz Golaszewski linux-gpio 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2build: fix configure error messages on missing functionsconfigure.ac+3 -31 reply
2/2tools: allow longer time periodsconfigure.ac tools/gpioget.c tools/gpiomon.c +3 more+45 -239 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [libgpiod][PATCH 0/2] gpio-tools: allow specifying longer time periods

From: Bartosz Golaszewski <[email protected]>

Hi Kent!

Gunnar Thörnqvist reported that he no longer can use a command like:

    $ gpioset -t 0 -p 3600s -c gpiochip0 17=0
    gpioset: invalid period: 3600s

Due to the above error. I realized we only allow ~35 minutes as we store milliseconds in 32-bit signed integers. Here's a proposal to allow longer time periods by using 64-bit variables.

Bartosz Golaszewski (2):
build: fix configure error messages on missing functions
tools: allow longer time periods

 configure.ac         |  8 +++++---
 tools/gpioget.c      |  4 ++--
 tools/gpiomon.c      | 19 ++++++++++++++-----
 tools/gpioset.c      | 16 ++++++++--------
 tools/tools-common.c | 22 ++++++++++++++++------
 tools/tools-common.h |  5 +++--
 6 files changed, 48 insertions(+), 26 deletions(-)
Signature · 1 line
2.40.1