Skip to content

ASoC: SOF: ipc4-pcm: Do not reset ChainDMA if it is not allocated

Peter Ujfalusi linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ASoC: SOF: ipc4-pcm: Use consistent name for snd_sof_pcm_stream pointersound/soc/sof/ipc4-pcm.c+11 -110 replies
2/4ASoC: SOF: ipc4-pcm: Use consistent name for sof_ipc4_timestamp_info pointersound/soc/sof/ipc4-pcm.c+20 -200 replies
3/4ASoC: SOF: ipc4-pcm: Introduce generic sof_ipc4_pcm_stream_privsound/soc/sof/ipc4-pcm.c+35 -80 replies
4/4ASoC: SOF: ipc4-pcm: Do not reset the ChainDMA if it has not been allocatedsound/soc/sof/ipc4-pcm.c+20 -40 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPierre-Louis BossartRanjani Sridharan
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] ASoC: SOF: ipc4-pcm: Do not reset ChainDMA if it is not allocated

Hi,

The current code will reset the ChainDMA on release unconditionally which can result the following error when the CHainDMA is not allocated:

ipc tx : 0xe040000|0x0: GLB_CHAIN_DMA
ipc tx reply: 0x2e000007|0x0: GLB_CHAIN_DMA FW reported error: 7 - Unsupported operation requested ipc error for msg 0xe040000|0x0
sof_pcm_stream_free: pcm_ops hw_free failed -22

Background:
Pulseaudio and Pipewire on startup opens all available streams and closes them without triggering a start (after probing it's capabilities).

Regards,
Peter
---
Peter Ujfalusi (4):
ASoC: SOF: ipc4-pcm: Use consistent name for snd_sof_pcm_stream
pointer
ASoC: SOF: ipc4-pcm: Use consistent name for sof_ipc4_timestamp_info
pointer
ASoC: SOF: ipc4-pcm: Introduce generic sof_ipc4_pcm_stream_priv
ASoC: SOF: ipc4-pcm: Do not reset the ChainDMA if it has not been
allocated

 sound/soc/sof/ipc4-pcm.c | 115 +++++++++++++++++++++++++++------------
 1 file changed, 79 insertions(+), 36 deletions(-)
Signature · 1 line
2.44.0