Skip to content

sched/topology: Optimize topology_span_sane()

Kyle Meyer lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 6 repliesIn review
  2. v12 patches 6 repliesSuperseded

Changes in v2 from the cover letter

* 1/2: Change for_each_cpu()'s description.
* 2/2: Add more information to the commit message.
* https://lore.kernel.org/linux-kernel/[email protected]/T/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2cpumask: Add for_each_cpu_from()include/linux/cpumask.h+10 -01 reply
2/2sched/topology: Optimize topology_span_sane()kernel/sched/topology.c+2 -45 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchYury NorovVincent GuittotValentin Schneider
1/2A-b R-b
2/2R-b A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] sched/topology: Optimize topology_span_sane()

A soft lockup is being detected in build_sched_domains() on 32 socket Sapphire Rapids systems with 3840 processors.

topology_span_sane(), called by build_sched_domains(), checks that each processor's non-NUMA scheduling domains are completely equal or completely disjoint. If a non-NUMA scheduling domain partially overlaps another, scheduling groups can break.

This series adds for_each_cpu_from() as a generic cpumask macro to optimize topology_span_sane() by removing duplicate comparisons. The total number of comparisons is reduced from N * (N - 1) to
N * (N - 1) / 2 on each non-NUMA scheduling domain level, decreasing the boot time by approximately 20 seconds and preventing the soft lockup on the mentioned systems.

Changes in v2:
* 1/2: Change for_each_cpu()'s description.
* 2/2: Add more information to the commit message.
* https://lore.kernel.org/linux-kernel/[email protected]/T/

Kyle Meyer (2):
cpumask: Add for_each_cpu_from()
sched/topology: Optimize topology_span_sane()

 include/linux/cpumask.h | 10 ++++++++++
 kernel/sched/topology.c |  6 ++----
 2 files changed, 12 insertions(+), 4 deletions(-)
Signature · 1 line
2.44.0