Skip to content

mlx5 misc fixes

Tariq Toukan netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest12 patches 3 repliesIn review 11 of 12 applied

Changes in v2 from the cover letter

- Updated patchset #6 per Jakub's comments.
- Added two multi-PF (socket-direct) fixes.

Patches in v2 11 of 12 applied

#Subject and filesSizeRepliesApplied
1/12net/mlx5: E-switch, store eswitch pointer before registering devlink_paramdrivers/net/ethernet/mellanox/mlx5/core/eswitch.c drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c+7 -60 repliesApplied
2/12net/mlx5: Register devlink first under devlink lockdrivers/net/ethernet/mellanox/mlx5/core/main.c drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c+20 -180 repliesApplied
3/12net/mlx5: offset comp irq index in name by onedrivers/net/ethernet/mellanox/mlx5/core/pci_irq.c+3 -10 repliesApplied
4/12net/mlx5: Properly link new fs rules into the treedrivers/net/ethernet/mellanox/mlx5/core/fs_core.c+2 -10 repliesApplied
5/12net/mlx5: Correctly compare pkt reformat idsdrivers/net/ethernet/mellanox/mlx5/core/fs_core.c+12 -20 repliesApplied
6/12net/mlx5e: RSS, Block changing channels number when RXFH is configureddrivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c+17 -00 repliesApplied
7/12net/mlx5e: Fix mlx5e_priv_init() cleanup flowdrivers/net/ethernet/mellanox/mlx5/core/en/selq.c drivers/net/ethernet/mellanox/mlx5/core/en_main.c+2 -20 repliesApplied
8/12net/mlx5e: HTB, Fix inconsistencies with QoS SQs numberdrivers/net/ethernet/mellanox/mlx5/core/en/qos.c+17 -160 repliesApplied
9/12net/mlx5e: Do not produce metadata freelist entries in Tx port ts WQE xmitdrivers/net/ethernet/mellanox/mlx5/core/en/ptp.h drivers/net/ethernet/mellanox/mlx5/core/en_tx.c+10 -50 repliesApplied
10/12net/mlx5e: RSS, Block XOR hash with over 128 channelsdrivers/net/ethernet/mellanox/mlx5/core/en/rqt.c drivers/net/ethernet/mellanox/mlx5/core/en/rqt.h drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c+34 -20 repliesApplied
11/12net/mlx5: Disallow SRIOV switchdev mode when in multi-PF netdevdrivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c+7 -00 repliesApplied
12/12net/mlx5: SD, Handle possible devcom ERR_PTRdrivers/net/ethernet/mellanox/mlx5/core/lib/sd.c+2 -23 replies

Reviews trailers per patch

11 of 12 patches have a Reviewed-by or Acked-by.

PatchMoshe ShemeshTariq ToukanMark BlochMohamed KhalfellaYuanyuan ZhongShay DroryDragos TatuleaGal Pressman
1/12R-b
2/12R-b
3/12R-b R-b R-b
4/12R-b R-b
5/12R-b R-b
6/12R-b
7/12R-b R-b
8/12R-b R-b
9/12R-b
10/12
11/12R-b R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v2 thread

Cover letter [PATCH net V2 00/12] mlx5 misc fixes

Hi,

This patchset provides bug fixes to mlx5 driver.

This is V2 of the series previously submitted as PR by Saeed:
https://lore.kernel.org/netdev/[email protected]/T/

Series generated against:
commit 237f3cf13b20 ("xsk: validate user input for XDP_{UMEM|COMPLETION}_FILL_RING")

Thanks,
Tariq.

V2:
- Updated patchset #6 per Jakub's comments.
- Added two multi-PF (socket-direct) fixes.

Carolina Jubran (4):
net/mlx5e: RSS, Block changing channels number when RXFH is configured net/mlx5e: Fix mlx5e_priv_init() cleanup flow
net/mlx5e: HTB, Fix inconsistencies with QoS SQs number net/mlx5e: RSS, Block XOR hash with over 128 channels

Cosmin Ratiu (2):
net/mlx5: Properly link new fs rules into the tree net/mlx5: Correctly compare pkt reformat ids

Michael Liang (1):
net/mlx5: offset comp irq index in name by one

Rahul Rameshbabu (1):
net/mlx5e: Do not produce metadata freelist entries in Tx port ts WQE
xmit

Shay Drory (2):
net/mlx5: E-switch, store eswitch pointer before registering
devlink_param
net/mlx5: Register devlink first under devlink lock

Tariq Toukan (2):
net/mlx5: Disallow SRIOV switchdev mode when in multi-PF netdev net/mlx5: SD, Handle possible devcom ERR_PTR

 .../net/ethernet/mellanox/mlx5/core/en/ptp.h  |  8 +++-
 .../net/ethernet/mellanox/mlx5/core/en/qos.c  | 33 +++++++-------
 .../net/ethernet/mellanox/mlx5/core/en/rqt.c  |  7 +++
 .../net/ethernet/mellanox/mlx5/core/en/rqt.h  |  1 +
 .../net/ethernet/mellanox/mlx5/core/en/selq.c |  2 +
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  | 45 ++++++++++++++++++-
 .../net/ethernet/mellanox/mlx5/core/en_main.c |  2 -
 .../net/ethernet/mellanox/mlx5/core/en_tx.c   |  7 ++-
 .../net/ethernet/mellanox/mlx5/core/eswitch.c |  9 ++--
 .../mellanox/mlx5/core/eswitch_offloads.c     | 11 +++++
 .../net/ethernet/mellanox/mlx5/core/fs_core.c | 17 +++++--
 .../net/ethernet/mellanox/mlx5/core/lib/sd.c  |  4 +-
 .../net/ethernet/mellanox/mlx5/core/main.c    | 37 ++++++++-------
 .../net/ethernet/mellanox/mlx5/core/pci_irq.c |  4 +-
 .../mellanox/mlx5/core/sf/dev/driver.c        |  1 -
 15 files changed, 133 insertions(+), 55 deletions(-)
Signature · 1 line
2.44.0