Skip to content

misc: Remove sprintf() due to macOS deprecation

Philippe Mathieu-Daudé qemu-arm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 13 repliesIn review
  2. v112 patches 12 repliesSuperseded

Changes in v2 from the cover letter

- Use snprintf() in patches 1-5

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13ui/console-vc: Replace sprintf() by snprintf()ui/console-vc.c+1 -12 replies
2/13hw/vfio/pci: Replace sprintf() by snprintf()hw/vfio/pci.c+1 -11 reply
3/13hw/ppc/spapr: Replace sprintf() by snprintf()hw/ppc/spapr.c+1 -12 replies
4/13hw/mips/malta: Add re-usable rng_seed_hex_new() methodhw/mips/malta.c+12 -82 replies
5/13hw/mips/malta: Replace sprintf() by snprintf()hw/mips/malta.c+2 -10 replies
6/13system/qtest: Replace sprintf() by g_string_append_printf()system/qtest.c+3 -51 reply
7/13util/hexdump: Rename @offset argument in qemu_hexdump_line()hw/virtio/vhost-vdpa.c include/qemu/cutils.h util/hexdump.c+21 -141 reply
8/13util/hexdump: Have qemu_hexdump_line() return heap allocated bufferhw/virtio/vhost-vdpa.c include/qemu/cutils.h util/hexdump.c+18 -91 reply
9/13util/hexdump: Replace sprintf() by g_string_append_printf()util/hexdump.c+8 -92 replies
10/13hw/scsi/scsi-disk: Use qemu_hexdump_line() to avoid sprintf()hw/scsi/scsi-disk.c+2 -61 reply
11/13hw/ide/atapi: Use qemu_hexdump_line() to avoid sprintf()hw/ide/atapi.c+2 -60 replies
12/13hw/dma/pl330: Use qemu_hexdump_line() to avoid sprintf()hw/dma/pl330.c+3 -90 replies
13/13backends/tpm: Use qemu_hexdump_line() to avoid sprintf()backends/tpm/tpm_util.c+8 -160 replies

Reviews trailers per patch

7 of 13 patches have a Reviewed-by or Acked-by.

PatchStefan BergerThomas HuthMarc-André LureauRichard HendersonHarsh Prateek Bora
1/13R-b R-b
2/13R-b
3/13R-b R-b
4/13
5/13
6/13R-b R-b
7/13R-b
8/13
9/13R-b
10/13
11/13
12/13
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/13] misc: Remove sprintf() due to macOS deprecation

Since v1:
- Use snprintf() in patches 1-5

Hi,

sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1, resulting in painful developper experience.

Suggestion to avoid the super-noisy warning on macOS forum are [*]:

* use -Wno-deprecated-declarations on the whole build
* surgically add #pragma clang diagnostic around each use.

None of these options seem reasonable, so we are somehow forced to spend time converting each sprintf() call, even if they are safe enough.

I'm so tired of seeing them than I started the conversion. This is the first part. Help for the rest is welcomed.

Regards,

Phil.

[*] https://forums.developer.apple.com/forums/thread/714675

Philippe Mathieu-Daudé (13):
ui/console-vc: Replace sprintf() by snprintf() hw/vfio/pci: Replace sprintf() by snprintf() hw/ppc/spapr: Replace sprintf() by snprintf() hw/mips/malta: Add re-usable rng_seed_hex_new() method hw/mips/malta: Replace sprintf() by snprintf() system/qtest: Replace sprintf() by g_string_append_printf() util/hexdump: Rename @offset argument in qemu_hexdump_line() util/hexdump: Have qemu_hexdump_line() return heap allocated buffer util/hexdump: Replace sprintf() by g_string_append_printf() hw/scsi/scsi-disk: Use qemu_hexdump_line() to avoid sprintf() hw/ide/atapi: Use qemu_hexdump_line() to avoid sprintf() hw/dma/pl330: Use qemu_hexdump_line() to avoid sprintf() backends/tpm: Use qemu_hexdump_line() to avoid sprintf()

 include/qemu/cutils.h   | 17 ++++++++++++++---
 backends/tpm/tpm_util.c | 24 ++++++++----------------
 hw/dma/pl330.c          | 12 +++---------
 hw/ide/atapi.c          |  8 ++------
 hw/mips/malta.c         | 23 ++++++++++++++---------
 hw/ppc/spapr.c          |  2 +-
 hw/scsi/scsi-disk.c     |  8 ++------
 hw/vfio/pci.c           |  2 +-
 hw/virtio/vhost-vdpa.c  | 11 ++++++-----
 system/qtest.c          |  8 +++-----
 ui/console-vc.c         |  2 +-
 util/hexdump.c          | 33 ++++++++++++++++++---------------
 12 files changed, 73 insertions(+), 77 deletions(-)
Signature · 1 line
2.41.0