Refactor default device atomic settings
Status from this message: Merged to drm-xe-next
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest5 patches 9 repliesApplied
- v55 patches 5 repliesSuperseded
- v45 patches 5 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 7 patches | 20 replies | Superseded | |
| v2 | 7 patches | 5 replies | Superseded | |
| v1 | 3 patches | 20 replies | Superseded |
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | drm/xe: Introduce has_atomic_enable_pte_bit device infodrivers/ drivers/ drivers/ | +6 | 0 replies | |
| 2/5 | drm/xe: Move vm bind bo validation to a helper functiondrivers/ | +43 | 0 replies | |
| 3/5 | drm/xe: Introduce has_device_atomics_on_smem device infodrivers/ drivers/ | +4 | 0 replies | |
| 4/5 | drm/xe: Add function to check if BO has single placementdrivers/ drivers/ | +15 | 0 replies | |
| 5/5 | drm/xe: Refactor default device atomic settingsdrivers/ drivers/ | +35 | 4 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Oak Zeng | José Roberto de Souza | Matthew Brost | Michal Mrozek | Lionel Landwerlin |
|---|---|---|---|---|---|
| Series | A-b | ||||
| 1/5 | R-b | R-b | |||
| 2/5 | R-b | R-b | R-b | ||
| 3/5 | R-b | R-b | |||
| 4/5 | R-b | ||||
| 5/5 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v6 0/5] Refactor default device atomic settings
The default behavior of device atomics depends on the VM type and buffer allocation types. Device atomics are expected to function with all types of allocations for traditional applications/APIs. Additionally, in compute/SVM API scenarios with fault mode or LR mode VMs, device atomics must work with single-region allocations. In all other cases device atomics should be disabled by default. PVC needs special care as it doesn't support device atomics on SMEM.
v6: Only check LR mode to determine compute API as fault
mode requires LR mode(Jose)
Set AE=1 on SMEM+LMEM allocation when a buffer is migrated to LMEM from SMEM(Brian)
v5: Fix broken atomics on PVC from v4 changes.
v4: Previous assumption that device atomics should be disabled
by default on SMEM only BO was wrong as traditional applications will not use such allocations for CPU atomics. So remove the VM bind flag and the query uAPI and instead refactor default device atomics settings as per VM type and buffer allocations.
v3: Capture ret value of xe_vm_bind_ioctl_validate_bo(Matt B).
Remove redundant coh_mode param from xe_vm_bind_ioctl_validate_bo(). Remove has_device_atomics_on_smem from xe_graphics_desc(Jose). Replace DRM_XE_QUERY_CONFIG_SUPP_DEV_ATOMIC_ON_SMEM with config flag DRM_XE_QUERY_CONFIG_FLAG_HAS_DEV_ATOMIC_ON_SMEM(Jose). Mention that PTE_AE will not be applied to userptr(Matt R)
v2: Add BO helper func in xe_vm_bind_ioctl()(Matt B).
Use XE_IOCTL_DBG for checks(Matt B).
Move platform checks with help of adding flags in intel_device_info(Matt B).
Add document for DRM_XE_VM_BIND_FLAG_DEVICE_ATOMICS(Matt B). Create query uAPI for this newly added VM bind flag(Jose, Lionel).
Nirmoy Das (5):
drm/xe: Introduce has_atomic_enable_pte_bit device info drm/xe: Move vm bind bo validation to a helper function drm/xe: Introduce has_device_atomics_on_smem device info drm/xe: Add function to check if BO has single placement drm/xe: Refactor default device atomic settings
drivers/gpu/drm/xe/xe_bo.c | 14 +++++ drivers/gpu/drm/xe/xe_bo.h | 1 + drivers/gpu/drm/xe/xe_device_types.h | 4 ++ drivers/gpu/drm/xe/xe_pci.c | 5 ++ drivers/gpu/drm/xe/xe_pci_types.h | 1 + drivers/gpu/drm/xe/xe_pt.c | 37 +++++++++++-- drivers/gpu/drm/xe/xe_vm.c | 79 ++++++++++++++++------------ 7 files changed, 103 insertions(+), 38 deletions(-)
Signature · 1 line
2.42.0