perf annotate: Add TUI support for data type profiling (v2)
Status from this message: Thanks, applied.
Get series with b4
b4 am [email protected]Versions newest first
v2 changes from the cover letter
* fix build errors when libslang2 or libdw is missing (Arnaldo)
* update commit messages with examples (Arnaldo)
* skip updating sample histogram for stack canary (Arnaldo)
* add Reviewed-by from Ian
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | perf annotate-data: Skip sample histogram for stack canarytools/ | +3 | 0 replies | |
| 2/7 | perf annotate: Show progress of sample processingtools/ | +13 | 0 replies | |
| 3/7 | perf annotate-data: Add hist_entry__annotate_data_tty()tools/ tools/ tools/ | +122 | 0 replies | |
| 4/7 | perf annotate-data: Add hist_entry__annotate_data_tui()tools/ tools/ tools/ +2 more | +324 | 0 replies | |
| 5/7 | perf annotate-data: Support event group display in TUItools/ | +40 | 0 replies | |
| 6/7 | perf report: Add a menu item to annotate data type in TUItools/ tools/ | +36 | 0 replies | |
| 7/7 | perf report: Do not collect sample histogram unnecessarilytools/ tools/ | +8 | 0 replies |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Ian Rogers | Arnaldo Carvalho de Melo |
|---|---|---|
| 1/7 | ||
| 2/7 | R-b | |
| 3/7 | R-b | |
| 4/7 | R-b | T-b |
| 5/7 | R-b | T-b |
| 6/7 | R-b | |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHSET 0/7] perf annotate: Add TUI support for data type profiling (v2)
Hello,
This is to support interactive TUI browser for type annotation.
v2 changes:
* fix build errors when libslang2 or libdw is missing (Arnaldo)
* update commit messages with examples (Arnaldo)
* skip updating sample histogram for stack canary (Arnaldo)
* add Reviewed-by from Ian
Like the normal (code) annotation, it should be able to display the data type annotation. Now perf annotate --data-type will show the result in TUI by default if it's enabled. Also perf report -s type can show the same output using a menu item.
It's still in a very early stage and supports the basic functionalities only. I'll work on more features like in the normal annotation browser later.
The code is also available at 'perf/annotate-data-tui-v2' branch at
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Thanks,
Namhyung
Namhyung Kim (7):
perf annotate-data: Skip sample histogram for stack canary perf annotate: Show progress of sample processing perf annotate-data: Add hist_entry__annotate_data_tty() perf annotate-data: Add hist_entry__annotate_data_tui() perf annotate-data: Support event group display in TUI perf report: Add a menu item to annotate data type in TUI perf report: Do not collect sample histogram unnecessarily
tools/perf/builtin-annotate.c | 149 ++++-------- tools/perf/builtin-report.c | 7 +- tools/perf/ui/browsers/Build | 1 + tools/perf/ui/browsers/annotate-data.c | 312 +++++++++++++++++++++++++ tools/perf/ui/browsers/hists.c | 31 +++ tools/perf/util/annotate-data.c | 113 +++++++++ tools/perf/util/annotate-data.h | 22 ++ tools/perf/util/annotate.c | 12 +- 8 files changed, 534 insertions(+), 113 deletions(-) create mode 100644 tools/perf/ui/browsers/annotate-data.c
base-commit: 9c3e9af74326978ba6f4432bb038e6c80f4f56fd
Signature · 1 line
2.44.0.478.gd926399ef9-goog