Skip to content

rockchip pcie3-phy separate refclk support

Niklas Cassel linux-arm-kernel linux-devicetree linux-phy linux-rockchip 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesApplied
  2. v12 patches 4 repliesApplied

Changes in v2 from the cover letter

-Picked up tags
-Rebased on phy/next

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2dt-bindings: phy: rockchip,pcie3-phy: add rockchip,rx-common-refclk-modeDocumentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml+10 -03 replies
2/2phy: rockchip-snps-pcie3: add support for rockchip,rx-common-refclk-modedrivers/phy/rockchip/phy-rockchip-snps-pcie3.c+37 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiSebastian Reichel
1/2A-b R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] rockchip pcie3-phy separate refclk support

This series is based on: linux-phy phy/next

Hello all,

The rockchip,pcie3-phy PHY in rk3588 is by default configured to run in "common reference clock" mode. (Which is a sensible default, as the most commonly used clock configuration is "common reference clock".)

However, PCIe also defines two other configurations where the Root Complex and Endpoint uses separate reference clocks: SRNS and SRIS.

Having the Root Complex PHY configured in "common reference clock mode" while having an Endpoint connected which is supplying its own reference clock (i.e. SRNS or SRIS configuration), will either result in the link training failing, or a highly unstable link that continuously jumps between link states L0 and recovery.

Add a rockchip specific device tree property that can be added to the rk3588 Root Complex device tree PHY node, if the connected Endpoint device is using a separate refererence clock. This way we will get a stable link when using an Endpoint configured in SRNS or SRIS mode.

Kind regards,
Niklas

Changes since V1:
-Picked up tags
-Rebased on phy/next

Niklas Cassel (2):
dt-bindings: phy: rockchip,pcie3-phy: add
rockchip,rx-common-refclk-mode
phy: rockchip-snps-pcie3: add support for
rockchip,rx-common-refclk-mode

 .../bindings/phy/rockchip,pcie3-phy.yaml      | 10 +++++
 .../phy/rockchip/phy-rockchip-snps-pcie3.c    | 37 +++++++++++++++++++
 2 files changed, 47 insertions(+)
Signature · 1 line
2.44.0