Skip to content

nfsdctl: add a new nfsdctl tool to nfs-utils

Jeff Layton linux-nfs 6 versions – In review

Get series with b4
b4 am [email protected] change-id 20240412-nfsdctl-fa8bd8430cfd

Versions newest first

  1. v6 Latest3 patches 12 repliesIn review
  2. v54 patches 1 replySuperseded
  3. v43 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches1 replySuperseded
v24 patches2 repliesSuperseded
v1 RFC2 patches0 repliesSuperseded

Changes in v6 from the cover letter

- make the default number of threads 16 in autostart
- doc updates

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nfsdctl: add the nfsdctl utility to nfs-utilsconfigure.ac utils/Makefile.am utils/nfsdctl/Makefile.am +4 more+2099 -00 replies
2/3nfsdctl: asciidoc source for the manpageutils/nfsdctl/nfsdctl.adoc+158 -00 replies
3/3systemd: use nfsdctl to start and stop the nfs serversystemd/nfs-server.service+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH nfs-utils v6 0/3] nfsdctl: add a new nfsdctl tool to nfs-utils

Hi Steve,

Here's an squashed version of the nfsdctl patches, that represents the latest changes. Let me know if you run into any other problems, and thanks for helping to test this!

---
Changes in v6:
- make the default number of threads 16 in autostart
- doc updates

Changes in v5:
- add support for pool-mode setting
- fix up the handling of nfsd_netlink.h in autoconf
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- add ability to specify an array of pool thread counts in nfs.conf
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- split nfsdctl.h so we can include the UAPI header as-is
- squash the patches together that added Lorenzo's version and convert it to the new interface
- adapt to latest version of netlink interface changes
+ have THREADS_SET/GET report an array of thread counts (one per pool)
+ pass scope in as a string to THREADS_SET instead of using unshare() trick

Changes in v2:
- Adapt to latest kernel netlink interface changes (in particular, send the leastime and gracetime when they are set in the config).
- More help text for different subcommands
- New nfsdctl(8) manpage
- Patch to make systemd preferentially use nfsdctl instead of rpc.nfsd
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Jeff Layton (3):
nfsdctl: add the nfsdctl utility to nfs-utils
nfsdctl: asciidoc source for the manpage
systemd: use nfsdctl to start and stop the nfs server

 configure.ac                 |   19 +
 systemd/nfs-server.service   |    4 +-
 utils/Makefile.am            |    4 +
 utils/nfsdctl/Makefile.am    |   13 +
 utils/nfsdctl/nfsd_netlink.h |   96 +++
 utils/nfsdctl/nfsdctl.8      |  304 ++++++++
 utils/nfsdctl/nfsdctl.adoc   |  158 +++++
 utils/nfsdctl/nfsdctl.c      | 1570 ++++++++++++++++++++++++++++++++++++++++++
 utils/nfsdctl/nfsdctl.h      |   93 +++
 9 files changed, 2259 insertions(+), 2 deletions(-)

---
base-commit: b76dbaa48f7c239accb0c2d1e1d51ddd73f4d6be
change-id: 20240412-nfsdctl-fa8bd8430cfd

Best regards,

Signature · 1 line
Jeff Layton <[email protected]>