mtd: spi-nor: spring cleaning
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 16 repliesIn review
- v16 patches 24 repliesSuperseded
Changes in v2 from the cover letter
- remove convert_addr, I've left page_size in the info, that might still come in handy for future flashes as they are getting bigger, although let's hope they have SFDP support..
- simplify the fast read flag handling
- reword the commit message of the .setup() callback removal patch
- introduce .deprecation_version and simplify the checking
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | mtd: spi-nor: Remove support for Xilinx S3AN flashesdrivers/ drivers/ drivers/ +1 more | +0 | 1 reply | |
| 2/6 | mtd: spi-nor: get rid of non-power-of-2 page size handlingdrivers/ drivers/ | +11 | 1 reply | |
| 3/6 | mtd: spi-nor: remove .setup() callbackdrivers/ drivers/ | +45 | 2 replies | |
| 4/6 | mtd: spi-nor: get rid of SPI_NOR_NO_FRdrivers/ drivers/ drivers/ | +17 | 3 replies | |
| 5/6 | mtd: spi-nor: simplify spi_nor_get_flash_info()drivers/ | +21 | 4 replies | |
| 6/6 | mtd: spi-nor: introduce support for displaying deprecation messagedrivers/ drivers/ | +13 | 4 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Tudor Ambarus | Pratyush Yadav | Ricardo Ribalda |
|---|---|---|---|
| 1/6 | A-b | R-b | A-b |
| 2/6 | A-b | R-b | |
| 3/6 | A-b | R-b | |
| 4/6 | R-b | R-b | |
| 5/6 | R-b | ||
| 6/6 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/6] mtd: spi-nor: spring cleaning
It's time for some spring cleaning. Remove the oddball xilinx flashes with non-power-of-2 page sizes.
Remove the .setup() callback, only the default callback is ever used and it is unlikely there is need for a custom setup.
Finally, the last patch is a proposal how to deprecate flashes, which are just detected by their id. We cannot really find out if there are boards out there which are using a particular flash. Thus, as a first step, we can print a warning during kernel startup. As a second step we might introduce a kernel config option to actually disable the flashes which has the deprecated flag.
v2:
- remove convert_addr, I've left page_size in the info, that might still come in handy for future flashes as they are getting bigger, although let's hope they have SFDP support..
- simplify the fast read flag handling
- reword the commit message of the .setup() callback removal patch
- introduce .deprecation_version and simplify the checking
Michael Walle (6):
mtd: spi-nor: Remove support for Xilinx S3AN flashes
mtd: spi-nor: get rid of non-power-of-2 page size handling
mtd: spi-nor: remove .setup() callback
mtd: spi-nor: get rid of SPI_NOR_NO_FR
mtd: spi-nor: simplify spi_nor_get_flash_info()
mtd: spi-nor: introduce support for displaying deprecation message
drivers/mtd/spi-nor/Makefile | 1 - drivers/mtd/spi-nor/core.c | 208 ++++++++++++++------------------- drivers/mtd/spi-nor/core.h | 15 +-- drivers/mtd/spi-nor/everspin.c | 19 ++- drivers/mtd/spi-nor/xilinx.c | 169 --------------------------- 5 files changed, 105 insertions(+), 307 deletions(-) delete mode 100644 drivers/mtd/spi-nor/xilinx.c
Signature · 1 line
2.39.2