Skip to content

RFC Replace community.general.zypper

[email protected] kdevops 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest22 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22blktests: Replace the use of community.general.zypperplaybooks/roles/blktests/tasks/install-deps/suse/main.yml+8 -190 replies
2/22bootlinux: Replace the use of the community.general.zypper moduleplaybooks/roles/bootlinux/tasks/install-deps/suse/main.yml+2 -20 replies
3/22btrfs_progs: Replace the use of the community.general.zypper moduleplaybooks/roles/btrfs_progs/tasks/install-deps/suse/main.yml+2 -20 replies
4/22build-qemu: Replace the use of the community.general.zypper moduleplaybooks/roles/build_qemu/tasks/install-deps/suse/main.yml+2 -10 replies
5/22create_partition: Replace the use of the community.general.zypper moduleplaybooks/roles/create_partition/tasks/install-deps/suse/main.yml+1 -10 replies
6/22cxl: Replace the use of the community.general.zypper moduleplaybooks/roles/cxl/tasks/install-deps/suse/main.yml+1 -20 replies
7/22devconfig: Replace the use of the community.general.zypper moduleplaybooks/roles/devconfig/tasks/install-deps/suse/main.yml+16 -150 replies
8/22kotd-rev-kernel: Replace the use of the community.general.zypper moduleplaybooks/roles/devconfig/tasks/kotd-rev-kernel/suse/main.yml+1 -50 replies
9/22fstests: Replace the use of the community.general.zypper moduleplaybooks/roles/fstests/tasks/install-deps/suse/main.yml+8 -190 replies
10/22fstests_prep_localhost: Replace the use of the community.general zypper moduleplaybooks/roles/fstests_prep_localhost/tasks/install-deps/suse/main.yml+1 -10 replies
11/22install-menuconfig-deps: Replace the use of the community.general.zypper moduleplaybooks/roles/install-menuconfig-deps/tasks/install-deps/suse/main.yml+2 -10 replies
12/22install_systemd_journal: Replace the use of the community.general.zypper moduleplaybooks/roles/install_systemd_journal_remote/tasks/install-deps/suse/main.yml+2 -10 replies
13/22install_systemd_timesyncd: Replace the use of the community.general.zypper moduleplaybooks/roles/install_systemd_timesyncd/tasks/install-deps/suse/main.yml+2 -10 replies
14/22install_terraform: Replace the use of the community.general.zypper moduleplaybooks/roles/install_terraform/tasks/install-deps/suse/main.yml+2 -10 replies
15/22install_vagrant: Replace the use of the community.general.zypper moduleplaybooks/roles/install_vagrant/tasks/install-deps/suse/main.yml+3 -50 replies
16/22kdc: Replace the use of the community.general.zypper moduleplaybooks/roles/kdc/tasks/install-deps/suse/main.yml+1 -10 replies
17/22krb5: Replace the use of the community.general.zypper moduleplaybooks/roles/krb5/tasks/install-deps/suse/main.yml+1 -20 replies
18/22ktls: Replace the use of the community.general.zypper moduleplaybooks/roles/ktls/tasks/install-deps/suse/main.yml+2 -20 replies
19/22libvirt_user: Replace the use of the community.general.zypper moduleplaybooks/roles/libvirt_user/tasks/install-deps/suse/main.yml+1 -10 replies
20/22nfsd: Replace the use of the community.general.zypper moduleplaybooks/roles/nfsd/tasks/install-deps/debian/main.yml playbooks/roles/nfsd/tasks/install-deps/redhat/main.yml playbooks/roles/nfsd/tasks/install-deps/suse/main.yml +4 more+42 -1120 replies
21/22pynfs: Replace the use of the community.general.zypper moduleplaybooks/roles/pynfs/tasks/install-deps/suse/main.yml+1 -10 replies
22/22selftests: Replace the use of the community.general.zypper moduleplaybooks/roles/selftests/tasks/install-deps/suse/main.yml+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/22] Replace community.general.zypper

From: Chuck Lever <[email protected]>

[email protected] reports:

Quoted 7 lines

So on a fresh new debian testing system I noticed we will have to install also now:

ansible-galaxy collection install ansible.posix --> due to our ansible.cfg stdout_callback=debug ansible-galaxy collection install community.general --> due to zypper !

Otherwise we get obscure errors.

This series surgically replaces the use of the zypper module to mitigate the dependency on the community.general collection.

There are a few spots where some extra arguments were used. Those spots need some review/testing attention. None of this has been tested yet, this post is just for comments / thinking out loud.

Chuck Lever (22):
blktests: Replace the use of community.general.zypper
bootlinux: Replace the use of the community.general.zypper module
btrfs_progs: Replace the use of the community.general.zypper module
build-qemu: Replace the use of the community.general.zypper module
create_partition: Replace the use of the community.general.zypper
module
cxl: Replace the use of the community.general.zypper module
devconfig: Replace the use of the community.general.zypper module
kotd-rev-kernel: Replace the use of the community.general.zypper
module
fstests: Replace the use of the community.general.zypper module
fstests_prep_localhost: Replace the use of the community.general
zypper module
install-menuconfig-deps: Replace the use of the
community.general.zypper module
install_systemd_journal: Replace the use of the
community.general.zypper module
install_systemd_timesyncd: Replace the use of the
community.general.zypper module
install_terraform: Replace the use of the community.general.zypper
module
install_vagrant: Replace the use of the community.general.zypper
module
kdc: Replace the use of the community.general.zypper module
krb5: Replace the use of the community.general.zypper module
ktls: Replace the use of the community.general.zypper module
libvirt_user: Replace the use of the community.general.zypper module
nfsd: Replace the use of the community.general.zypper module
pynfs: Replace the use of the community.general.zypper module
selftests: Replace the use of the community.general.zypper module

 .../blktests/tasks/install-deps/suse/main.yml | 27 ++++--------
 .../tasks/install-deps/suse/main.yml          |  4 +-
 .../tasks/install-deps/suse/main.yml          |  4 +-
 .../tasks/install-deps/suse/main.yml          |  3 +-
 .../tasks/install-deps/suse/main.yml          |  2 +-
 .../cxl/tasks/install-deps/suse/main.yml      |  3 +-
 .../tasks/install-deps/suse/main.yml          | 31 +++++++-------
 .../tasks/kotd-rev-kernel/suse/main.yml       |  6 +--
 .../fstests/tasks/install-deps/suse/main.yml  | 27 ++++--------
 .../tasks/install-deps/suse/main.yml          |  2 +-
 .../tasks/install-deps/suse/main.yml          |  3 +-
 .../tasks/install-deps/suse/main.yml          |  3 +-
 .../tasks/install-deps/suse/main.yml          |  3 +-
 .../tasks/install-deps/suse/main.yml          |  3 +-
 .../tasks/install-deps/suse/main.yml          |  8 ++--
 .../kdc/tasks/install-deps/suse/main.yml      |  2 +-
 .../krb5/tasks/install-deps/suse/main.yml     |  3 +-
 .../ktls/tasks/install-deps/suse/main.yml     |  4 +-
 .../tasks/install-deps/suse/main.yml          |  2 +-
 .../nfsd/tasks/install-deps/debian/main.yml   | 36 ----------------
 .../nfsd/tasks/install-deps/redhat/main.yml   | 33 ---------------
 .../nfsd/tasks/install-deps/suse/main.yml     | 34 ---------------
 playbooks/roles/nfsd/tasks/main.yml           | 42 +++++++++++++++----
 playbooks/roles/nfsd/vars/Debian.yml          |  3 ++
 playbooks/roles/nfsd/vars/RedHat.yml          |  2 +
 playbooks/roles/nfsd/vars/Suse.yml            |  4 ++
 .../pynfs/tasks/install-deps/suse/main.yml    |  2 +-
 .../tasks/install-deps/suse/main.yml          |  2 +-
 28 files changed, 102 insertions(+), 196 deletions(-)
 delete mode 100644 playbooks/roles/nfsd/tasks/install-deps/debian/main.yml
 delete mode 100644 playbooks/roles/nfsd/tasks/install-deps/redhat/main.yml
 delete mode 100644 playbooks/roles/nfsd/tasks/install-deps/suse/main.yml

base-commit: 9f538b3b87d15eebf60ead16c666ab7e433a5075

Signature · 1 line
2.44.0