crypto: ecdh & ecc: Fix private key byte ordering issues
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 4 repliesIn review
- v22 patches 2 repliesSuperseded
- v12 patches 5 repliesSuperseded
Changes in v3 from the cover letter
- Added Jarkko's A-b tag
- Expanded on the description of changes to ecc_gen_privkey (2/2)
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | crypto: ecdh - Pass private key in proper byte order to check valid keycrypto/ | +8 | 2 replies | |
| 2/2 | crypto: ecdh & ecc - Initialize ctx->private_key in proper byte ordercrypto/ crypto/ include/ | +15 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Jarkko Sakkinen |
|---|---|
| 1/2 | A-b |
| 2/2 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/2] crypto: ecdh & ecc: Fix private key byte ordering issues
The 1st patch fixes a byte ordering issue where ctx->private_key is currently passed to ecc_is_key_valid but the key is in reverse byte order. To solve this issue it introduces the variable 'priv', that is already used throughout the ecc and ecdh code bases for a private key in proper byte order, and calls ecc_is_key_valid with 'priv'. Note that ecc_gen_privkey also calls __ecc_is_key_valid with 'priv' already.
The 2nd patch gets rid of the 'priv' variable wherever it is used to hold a private key (byte-swapped initialized from ctx->private_key) in proper byte order and uses ctx->private_key directly that is now initialized in proper byte order.
Regards,
Stefan
v3:
- Added Jarkko's A-b tag
- Expanded on the description of changes to ecc_gen_privkey (2/2)
v2:
- Added missing zeroizing of priv variable (1/2)
- Improved patch description (2/2)
Stefan Berger (2):
crypto: ecdh - Pass private key in proper byte order to check valid
key
crypto: ecdh & ecc - Initialize ctx->private_key in proper byte order
crypto/ecc.c | 29 ++++++++++------------------- crypto/ecdh.c | 9 ++++++--- include/crypto/internal/ecc.h | 3 ++- 3 files changed, 18 insertions(+), 23 deletions(-)
Signature · 1 line
2.43.0