Skip to content

Consistently prefer sysfs/json events

Ian Rogers bpf linux-perf-users linux-riscv lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest16 patches 14 repliesIn review
  2. v19 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16perf parse-events: Factor out '<event_or_pmu>/.../' parsingtools/perf/util/parse-events.c tools/perf/util/parse-events.h tools/perf/util/parse-events.y+80 -730 replies
2/16perf parse-events: Directly pass PMU to parse_events_add_pmutools/perf/util/parse-events.c+17 -290 replies
3/16perf parse-events: Avoid copying an empty listtools/perf/util/parse-events.c+13 -120 replies
4/16perf pmu: Refactor perf_pmu__matchtools/perf/util/parse-events.c tools/perf/util/pmu.c tools/perf/util/pmu.h+22 -260 replies
5/16perf tests parse-events: Use branches rather than cache-referencestools/perf/tests/parse-events.c+3 -30 replies
6/16perf parse-events: Legacy cache names on all PMUs and lower prioritytools/perf/util/parse-events.c tools/perf/util/parse-events.h+32 -90 replies
7/16perf parse-events: Handle PE_TERM_HW in name_or_rawtools/perf/util/parse-events.y+5 -260 replies
8/16perf parse-events: Constify parse_events_add_numerictools/perf/util/parse-events.c tools/perf/util/parse-events.h+12 -100 replies
9/16perf parse-events: Prefer sysfs/json hardware events over legacytools/perf/util/parse-events.c tools/perf/util/parse-events.h tools/perf/util/parse-events.l +1 more+103 -680 replies
10/16perf parse-events: Inline parse_events_update_liststools/perf/util/parse-events.c tools/perf/util/parse-events.h tools/perf/util/parse-events.y+25 -310 replies
11/16perf parse-events: Improve error message for bad numberstools/perf/util/parse-events.l+24 -166 replies
12/16perf parse-events: Inline parse_events_evlist_errortools/perf/util/parse-events.c tools/perf/util/parse-events.h tools/perf/util/parse-events.y+8 -130 replies
13/16perf parse-events: Improvements to modifier parsingtools/perf/util/parse-events.c tools/perf/util/parse-events.h tools/perf/util/parse-events.l +1 more+194 -1825 replies
14/16perf parse-event: Constify event_symbol arraystools/perf/util/parse-events.c tools/perf/util/parse-events.h+4 -40 replies
15/16perf parse-events: Minor grouping tidy uptools/perf/util/parse-events.c tools/perf/util/parse-events.y+6 -10 replies
16/16perf parse-events: Tidy the setting of the default event nametools/perf/util/parse-events.c tools/perf/util/parse-events.h tools/perf/util/parse-events.l +1 more+19 -70 replies

Reviews trailers per patch

None of the 16 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAtish PatraKan Liang
SeriesT-b R-b
1/16
2/16
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/16] Consistently prefer sysfs/json events

As discussed in:
https://lore.kernel.org/lkml/[email protected]/
preferring sysfs/json events consistently (with or without a given PMU) will enable RISC-V's hope to customize legacy events in the perf tool.

Some minor clean-up is performed on the way.

v2. Additional cleanup particularly adding better error messages. Fix
some line length issues on the earlier patches.

Ian Rogers (16):
perf parse-events: Factor out '<event_or_pmu>/.../' parsing perf parse-events: Directly pass PMU to parse_events_add_pmu perf parse-events: Avoid copying an empty list
perf pmu: Refactor perf_pmu__match
perf tests parse-events: Use branches rather than cache-references perf parse-events: Legacy cache names on all PMUs and lower priority perf parse-events: Handle PE_TERM_HW in name_or_raw
perf parse-events: Constify parse_events_add_numeric
perf parse-events: Prefer sysfs/json hardware events over legacy perf parse-events: Inline parse_events_update_lists
perf parse-events: Improve error message for bad numbers perf parse-events: Inline parse_events_evlist_error
perf parse-events: Improvements to modifier parsing
perf parse-event: Constify event_symbol arrays
perf parse-events: Minor grouping tidy up
perf parse-events: Tidy the setting of the default event name

 tools/perf/tests/parse-events.c |   6 +-
 tools/perf/util/parse-events.c  | 482 ++++++++++++++++----------------
 tools/perf/util/parse-events.h  |  49 ++--
 tools/perf/util/parse-events.l  | 196 +++++++++----
 tools/perf/util/parse-events.y  | 261 +++++++----------
 tools/perf/util/pmu.c           |  27 +-
 tools/perf/util/pmu.h           |   2 +-
 7 files changed, 540 insertions(+), 483 deletions(-)
Signature · 1 line
2.44.0.683.g7961c838ac-goog