Skip to content

target/ppc: Move fixed-point insns to

Chinmay Rath qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 4 repliesIn review
  2. v18 patches 18 repliesSuperseded

Change log from the cover letter

v2 : Implemented code clean-ups as per comments by Richard in

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8target/ppc: Move mul{li, lw, lwo, hw, hwu} instructions to decodetree.target/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/fixedpoint-impl.c.inc+75 -890 replies
2/8target/ppc: Make divw[u] handler method decodetree compatible.target/ppc/translate.c+5 -40 replies
3/8target/ppc: Move divw[u, e, eu] instructions to decodetree.target/ppc/helper.h target/ppc/insn32.decode target/ppc/int_helper.c +2 more+33 -350 replies
4/8target/ppc: Move neg, darn, mod{sw, uw} to decodetree.target/ppc/helper.h target/ppc/insn32.decode target/ppc/int_helper.c +2 more+56 -600 replies
5/8target/ppc: Move multiply fixed-point insns (64-bit operands) to decodetree.target/ppc/insn32.decode target/ppc/translate.c target/ppc/translate/fixedpoint-impl.c.inc+94 -1010 replies
6/8target/ppc: Move div/mod fixed-point insns (64 bits operands) to decodetree.target/ppc/helper.h target/ppc/insn32.decode target/ppc/int_helper.c +2 more+42 -684 replies
7/8target/ppc: Move cmp{rb, eqb}, tw[i], td[i], isel instructions to decodetree.target/ppc/excp_helper.c target/ppc/helper.h target/ppc/insn32.decode +3 more+145 -1360 replies
8/8target/ppc: Move logical fixed-point instructions to decodetree.target/ppc/helper.h target/ppc/insn32.decode target/ppc/int_helper.c +2 more+316 -3680 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/8] target/ppc: Move fixed-point insns to

Moving all fixed-point instructions of the following type to decodetree specification : arithmetic, compare, trap, select and logical.

Change log :
v2 : Implemented code clean-ups as per comments by Richard in

     patches 1/8, 5/8 and 7/8 of v1.

v1 : https://lore.kernel.org/qemu-devel/[email protected]/

Chinmay Rath (8):
target/ppc: Move mul{li, lw, lwo, hw, hwu} instructions to decodetree. target/ppc: Make divw[u] handler method decodetree compatible. target/ppc: Move divw[u, e, eu] instructions to decodetree. target/ppc: Move neg, darn, mod{sw, uw} to decodetree. target/ppc: Move multiply fixed-point insns (64-bit operands) to
decodetree.
target/ppc: Move div/mod fixed-point insns (64 bits operands) to
decodetree.
target/ppc: Move cmp{rb, eqb}, tw[i], td[i], isel instructions to
decodetree.
target/ppc: Move logical fixed-point instructions to decodetree.

 target/ppc/helper.h                        |  26 +-
 target/ppc/insn32.decode                   |  93 +++
 target/ppc/excp_helper.c                   |   4 +-
 target/ppc/int_helper.c                    |  24 +-
 target/ppc/translate.c                     | 841 +--------------------
 target/ppc/translate/fixedpoint-impl.c.inc | 631 ++++++++++++++++
 6 files changed, 762 insertions(+), 857 deletions(-)
Signature · 1 line
2.39.3