Skip to content

net: ipa: header hygiene

Alex Elder linux-arm-msm lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 0 repliesApplied 7/7

Patches in v1 All 7 applied

#Subject and filesSizeRepliesApplied
1/7net: ipa: include some standard header filesdrivers/net/ipa/data/ipa_data-v3.1.c drivers/net/ipa/data/ipa_data-v3.5.1.c drivers/net/ipa/data/ipa_data-v4.11.c +29 more+84 -320 repliesApplied
2/7net: ipa: remove unneeded standard includesdrivers/net/ipa/gsi.c drivers/net/ipa/gsi.h drivers/net/ipa/ipa.h +14 more+12 -390 repliesApplied
3/7net: ipa: include "ipa_interrupt.h" where neededdrivers/net/ipa/ipa.h drivers/net/ipa/ipa_cmd.c drivers/net/ipa/ipa_endpoint.c +2 more+8 -30 repliesApplied
4/7net: ipa: add some needed struct declarationsdrivers/net/ipa/gsi_private.h drivers/net/ipa/ipa_endpoint.h drivers/net/ipa/ipa_interrupt.h +1 more+7 -40 repliesApplied
5/7net: ipa: eliminate unneeded struct declarationsdrivers/net/ipa/gsi.h drivers/net/ipa/gsi_trans.h drivers/net/ipa/ipa.h +4 more+3 -150 repliesApplied
6/7net: ipa: more include file cleanupdrivers/net/ipa/data/ipa_data-v3.1.c drivers/net/ipa/data/ipa_data-v3.5.1.c drivers/net/ipa/data/ipa_data-v4.11.c +29 more+35 -400 repliesApplied
7/7net: ipa: sort all includesdrivers/net/ipa/gsi.c drivers/net/ipa/gsi.h drivers/net/ipa/gsi_reg.c +25 more+107 -980 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/7] net: ipa: header hygiene

The end result of this series is that the list of files included in every IPA source file will be maintained in sorted order. This imposes some consistency that was previously not possible.

If an IPA header file requires a symbol or type declared in another header, that other header must be included. E.g., if bool or u32 type is used in a function declaration in an IPA header file, the IPA header must include <linux/types.h>.

If a type used is just a struct or union *pointer* or enum type (and no members within these types are needed), then these types only need to be *declared* within the header that uses it.

This is sufficient, but in addition, this series removes includes of files that aren't necessary, as well as unneeded type declarations.

-Alex

Alex Elder (7):
net: ipa: include some standard header files
net: ipa: remove unneeded standard includes
net: ipa: include "ipa_interrupt.h" where needed
net: ipa: add some needed struct declarations
net: ipa: eliminate unneeded struct declarations
net: ipa: more include file cleanup
net: ipa: sort all includes

 drivers/net/ipa/data/ipa_data-v3.1.c   |  5 +++--
 drivers/net/ipa/data/ipa_data-v3.5.1.c |  5 +++--
 drivers/net/ipa/data/ipa_data-v4.11.c  |  5 +++--
 drivers/net/ipa/data/ipa_data-v4.2.c   |  5 +++--
 drivers/net/ipa/data/ipa_data-v4.5.c   |  5 +++--
 drivers/net/ipa/data/ipa_data-v4.7.c   |  5 +++--
 drivers/net/ipa/data/ipa_data-v4.9.c   |  5 +++--
 drivers/net/ipa/data/ipa_data-v5.0.c   |  5 +++--
 drivers/net/ipa/data/ipa_data-v5.5.c   |  5 +++--
 drivers/net/ipa/gsi.c                  | 18 ++++++++---------
 drivers/net/ipa/gsi.h                  | 10 +++-------
 drivers/net/ipa/gsi_private.h          |  7 ++++---
 drivers/net/ipa/gsi_reg.c              |  6 +++---
 drivers/net/ipa/gsi_trans.c            | 12 ++++++------
 drivers/net/ipa/gsi_trans.h            |  9 ++++-----
 drivers/net/ipa/ipa.h                  | 15 +++++---------
 drivers/net/ipa/ipa_cmd.c              | 13 +++++++------
 drivers/net/ipa/ipa_cmd.h              | 10 +++-------
 drivers/net/ipa/ipa_data.h             |  4 ++--
 drivers/net/ipa/ipa_endpoint.c         | 19 ++++++++++--------
 drivers/net/ipa/ipa_endpoint.h         |  4 ++--
 drivers/net/ipa/ipa_gsi.c              |  7 ++++---
 drivers/net/ipa/ipa_interrupt.c        | 10 +++++-----
 drivers/net/ipa/ipa_interrupt.h        |  6 ++++--
 drivers/net/ipa/ipa_main.c             | 27 +++++++++++++-------------
 drivers/net/ipa/ipa_mem.c              | 15 +++++++-------
 drivers/net/ipa/ipa_mem.h              |  4 +++-
 drivers/net/ipa/ipa_modem.c            | 14 ++++++-------
 drivers/net/ipa/ipa_modem.h            |  5 +++--
 drivers/net/ipa/ipa_power.c            |  8 ++++----
 drivers/net/ipa/ipa_power.h            |  5 +++--
 drivers/net/ipa/ipa_qmi.c              | 10 +++-------
 drivers/net/ipa/ipa_qmi.h              |  4 +++-
 drivers/net/ipa/ipa_qmi_msg.c          |  3 ++-
 drivers/net/ipa/ipa_qmi_msg.h          |  3 ++-
 drivers/net/ipa/ipa_reg.c              |  4 ++--
 drivers/net/ipa/ipa_reg.h              |  6 +-----
 drivers/net/ipa/ipa_resource.c         |  3 +--
 drivers/net/ipa/ipa_smp2p.c            | 10 +++++-----
 drivers/net/ipa/ipa_sysfs.c            |  7 +++----
 drivers/net/ipa/ipa_sysfs.h            |  4 +---
 drivers/net/ipa/ipa_table.c            | 19 ++++++++----------
 drivers/net/ipa/ipa_uc.c               | 10 ++++++----
 drivers/net/ipa/ipa_uc.h               |  3 +--
 drivers/net/ipa/ipa_version.h          |  4 +++-
 drivers/net/ipa/reg.h                  |  8 +++++---
 drivers/net/ipa/reg/gsi_reg-v3.1.c     |  8 +++++---
 drivers/net/ipa/reg/gsi_reg-v3.5.1.c   |  8 +++++---
 drivers/net/ipa/reg/gsi_reg-v4.0.c     |  8 +++++---
 drivers/net/ipa/reg/gsi_reg-v4.11.c    |  8 +++++---
 drivers/net/ipa/reg/gsi_reg-v4.5.c     |  8 +++++---
 drivers/net/ipa/reg/gsi_reg-v4.9.c     |  8 +++++---
 drivers/net/ipa/reg/gsi_reg-v5.0.c     |  8 +++++---
 drivers/net/ipa/reg/ipa_reg-v3.1.c     |  6 ++++--
 drivers/net/ipa/reg/ipa_reg-v3.5.1.c   |  6 ++++--
 drivers/net/ipa/reg/ipa_reg-v4.11.c    |  6 ++++--
 drivers/net/ipa/reg/ipa_reg-v4.2.c     |  6 ++++--
 drivers/net/ipa/reg/ipa_reg-v4.5.c     |  6 ++++--
 drivers/net/ipa/reg/ipa_reg-v4.7.c     |  6 ++++--
 drivers/net/ipa/reg/ipa_reg-v4.9.c     |  6 ++++--
 drivers/net/ipa/reg/ipa_reg-v5.0.c     |  6 ++++--
 drivers/net/ipa/reg/ipa_reg-v5.5.c     |  6 +++---
 62 files changed, 253 insertions(+), 228 deletions(-)
Signature · 1 line
2.40.1